src/effects/SkBlurMask.cpp - Issue 292773003: fix off-by-one error in texture coordinate calculations for rrect gpu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBlurMask.cpp

Issue 292773003: fix off-by-one error in texture coordinate calculations for rrect gpu (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: disable gm for rebaseline Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkBlurMask.cpp

diff --git a/src/effects/SkBlurMask.cpp b/src/effects/SkBlurMask.cpp

index bf50845ab6cb1d308562ea44fa279133bcafd46f..1fd32f09383c9894f555744a1014e77b075c7d60 100644

--- a/src/effects/SkBlurMask.cpp

+++ b/src/effects/SkBlurMask.cpp

@@ -483,6 +483,8 @@ bool SkBlurMask::BoxBlur(SkMask* dst, const SkMask& src,

SkScalar sigma, SkBlurStyle style, SkBlurQuality quality,

SkIPoint* margin, bool force_quality) {

+ SkDebugf( "Blurring something: sigma=%f\n", sigma );

bsalomon 2014/05/19 18:39:26 should prolly remove this, otherwise lgtm.

if (src.fFormat != SkMask::kA8_Format) {

return false;

}

« no previous file with comments | « expectations/gm/ignored-tests.txt ('k') | src/effects/SkBlurMaskFilter.cpp » ('j') | no next file with comments »