Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/effects/SkBlurMask.cpp

Issue 292773003: fix off-by-one error in texture coordinate calculations for rrect gpu (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: disable gm for rebaseline Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « expectations/gm/ignored-tests.txt ('k') | src/effects/SkBlurMaskFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2006 The Android Open Source Project 3 * Copyright 2006 The Android Open Source Project
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 8
9 9
10 #include "SkBlurMask.h" 10 #include "SkBlurMask.h"
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 // a bug in gcc98 476 // a bug in gcc98
477 void SkMask_FreeImage(uint8_t* image); 477 void SkMask_FreeImage(uint8_t* image);
478 void SkMask_FreeImage(uint8_t* image) { 478 void SkMask_FreeImage(uint8_t* image) {
479 SkMask::FreeImage(image); 479 SkMask::FreeImage(image);
480 } 480 }
481 481
482 bool SkBlurMask::BoxBlur(SkMask* dst, const SkMask& src, 482 bool SkBlurMask::BoxBlur(SkMask* dst, const SkMask& src,
483 SkScalar sigma, SkBlurStyle style, SkBlurQuality qualit y, 483 SkScalar sigma, SkBlurStyle style, SkBlurQuality qualit y,
484 SkIPoint* margin, bool force_quality) { 484 SkIPoint* margin, bool force_quality) {
485 485
486 SkDebugf( "Blurring something: sigma=%f\n", sigma );
bsalomon 2014/05/19 18:39:26 should prolly remove this, otherwise lgtm.
487
486 if (src.fFormat != SkMask::kA8_Format) { 488 if (src.fFormat != SkMask::kA8_Format) {
487 return false; 489 return false;
488 } 490 }
489 491
490 // Force high quality off for small radii (performance) 492 // Force high quality off for small radii (performance)
491 if (!force_quality && sigma <= SkIntToScalar(2)) { 493 if (!force_quality && sigma <= SkIntToScalar(2)) {
492 quality = kLow_SkBlurQuality; 494 quality = kLow_SkBlurQuality;
493 } 495 }
494 496
495 SkScalar passRadius; 497 SkScalar passRadius;
(...skipping 491 matching lines...) Expand 10 before | Expand all | Expand 10 after
987 (void)autoCall.detach(); 989 (void)autoCall.detach();
988 } 990 }
989 991
990 if (style == kInner_SkBlurStyle) { 992 if (style == kInner_SkBlurStyle) {
991 dst->fBounds = src.fBounds; // restore trimmed bounds 993 dst->fBounds = src.fBounds; // restore trimmed bounds
992 dst->fRowBytes = src.fRowBytes; 994 dst->fRowBytes = src.fRowBytes;
993 } 995 }
994 996
995 return true; 997 return true;
996 } 998 }
OLDNEW
« no previous file with comments | « expectations/gm/ignored-tests.txt ('k') | src/effects/SkBlurMaskFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698