Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292773003: fix off-by-one error in texture coordinate calculations for rrect gpu (Closed)

Created:
6 years, 7 months ago by humper
Modified:
6 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix off-by-one error in texture coordinate calculations for rrect gpu blur; output now matches CPU BUG= Committed: http://code.google.com/p/skia/source/detail?r=14788

Patch Set 1 #

Patch Set 2 : disable gm for rebaseline #

Total comments: 1

Patch Set 3 : remove debug statement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
humper
ptal
6 years, 7 months ago (2014-05-19 18:06:33 UTC) #1
bsalomon
https://codereview.chromium.org/292773003/diff/20001/src/effects/SkBlurMask.cpp File src/effects/SkBlurMask.cpp (right): https://codereview.chromium.org/292773003/diff/20001/src/effects/SkBlurMask.cpp#newcode486 src/effects/SkBlurMask.cpp:486: SkDebugf( "Blurring something: sigma=%f\n", sigma ); should prolly remove ...
6 years, 7 months ago (2014-05-19 18:39:26 UTC) #2
humper
On 2014/05/19 18:39:26, bsalomon wrote: > https://codereview.chromium.org/292773003/diff/20001/src/effects/SkBlurMask.cpp > File src/effects/SkBlurMask.cpp (right): > > https://codereview.chromium.org/292773003/diff/20001/src/effects/SkBlurMask.cpp#newcode486 > ...
6 years, 7 months ago (2014-05-19 18:39:49 UTC) #3
humper
The CQ bit was checked by humper@google.com
6 years, 7 months ago (2014-05-19 18:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/292773003/40001
6 years, 7 months ago (2014-05-19 18:46:50 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 18:51:06 UTC) #6
Message was sent while issue was closed. 
Change committed as 14788

Powered by Google App Engine
This is Rietveld 408576698