chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java - Issue 2927723003: [Android Refactor] Merge WebappDataStorage#LAST_USED_UNSET and LAST_USED_INVALID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java

Issue 2927723003: [Android Refactor] Merge WebappDataStorage#LAST_USED_UNSET and LAST_USED_INVALID (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java

index 1997ce97f279cb9b1ced3daafedd907400a81a4b..2880e3f9b30ee9ae0eaf376dba7bb3dbe84842f0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java

@@ -117,8 +117,10 @@ public class WebappRegistry {

@Override

protected final void onPostExecute(WebappDataStorage storage) {

- // Guarantee that last used time != WebappDataStorage.LAST_USED_INVALID. Must be

- // run on the main thread as SharedPreferences.Editor.apply() is called.

+ // Update the last used time in order to prevent

+ // {@link WebappRegistry@unregisterOldWebapps()} from deleting the

+ // WebappDataStorage. Must be run on the main thread as

+ // SharedPreferences.Editor.apply() is called.

mStorages.put(webappId, storage);

mPreferences.edit().putStringSet(KEY_WEBAPP_SET, mStorages.keySet()).apply();

storage.updateLastUsedTime();