Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2927663002: Port two completion contributors for use by plugins (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org, mfairhurst, maxkim
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6446 lines, -2 lines) Patch
M pkg/analyzer_plugin/lib/src/utilities/completion/completion_core.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer_plugin/lib/src/utilities/completion/suggestion_builder.dart View 1 chunk +193 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/src/utilities/documentation.dart View 1 chunk +71 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/completion/inherited_reference_contributor.dart View 1 chunk +147 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/completion/suggestion_builder.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/completion/type_member_contributor.dart View 1 chunk +463 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/support/abstract_context.dart View 3 chunks +8 lines, -1 line 0 comments Download
A pkg/analyzer_plugin/test/utilities/completion/completion_contributor_util.dart View 1 chunk +569 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/utilities/completion/flutter_util.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/utilities/completion/inherited_reference_contributor_test.dart View 1 chunk +641 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/utilities/completion/replacement_range.dart View 1 chunk +68 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/utilities/completion/test_all.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/utilities/completion/type_member_contributor_test.dart View 1 chunk +4218 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/utilities/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
I think this should be the last support needed to be able to move the ...
3 years, 6 months ago (2017-06-06 22:37:59 UTC) #2
danrubel
LGTM
3 years, 6 months ago (2017-06-07 01:59:18 UTC) #3
scheglov
LGTM
3 years, 6 months ago (2017-06-07 15:58:55 UTC) #4
Brian Wilkerson
3 years, 6 months ago (2017-06-07 16:14:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a724f7093d3d4d16dcf9306f89da30ccdab328d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698