Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: components/browser_watcher/stability_paths_unittest.cc

Issue 2927653003: Stability instrumentation: add a Vectored Exception Handler (Closed)
Patch Set: merge Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/stability_paths_unittest.cc
diff --git a/components/browser_watcher/stability_paths_unittest.cc b/components/browser_watcher/stability_paths_unittest.cc
index 4b9eea086ac99421d67acef031f207756376799c..7a8f6ceb281da5912022d3fc24634e9130880ef5 100644
--- a/components/browser_watcher/stability_paths_unittest.cc
+++ b/components/browser_watcher/stability_paths_unittest.cc
@@ -4,14 +4,87 @@
#include "components/browser_watcher/stability_paths.h"
+#include "base/files/file_enumerator.h"
+#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_file.h"
#include "base/files/scoped_temp_dir.h"
+#include "base/process/process.h"
+#include "base/test/multiprocess_test.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/multiprocess_func_list.h"
namespace browser_watcher {
+class StabilityPathsMultiProcTest : public base::MultiProcessTest {};
+
+MULTIPROCESS_TEST_MAIN(DummyProcess) {
+ return 0;
+}
+
+TEST_F(StabilityPathsMultiProcTest, GetStabilityFileForProcessTest) {
+ const base::FilePath empty_path;
+
+ // Get the path for the current process.
+ base::FilePath stability_path;
+ ASSERT_TRUE(GetStabilityFileForProcess(base::Process::Current(), empty_path,
+ &stability_path));
+
+ // Ensure requesting a second time produces the same.
+ base::FilePath stability_path_two;
+ ASSERT_TRUE(GetStabilityFileForProcess(base::Process::Current(), empty_path,
+ &stability_path_two));
+ EXPECT_EQ(stability_path, stability_path_two);
+
+ // Ensure a different process has a different stability path.
+ base::SpawnChildResult spawn_result = SpawnChild("DummyProcess");
+ base::FilePath stability_path_other;
+ ASSERT_TRUE(GetStabilityFileForProcess(spawn_result.process, empty_path,
+ &stability_path_other));
+ EXPECT_NE(stability_path, stability_path_other);
+}
+
+TEST(StabilityPathsTest,
+ GetStabilityFilePatternMatchesGetStabilityFileForProcessResult) {
+ // GetStabilityFileForProcess file names must match GetStabilityFilePattern
+ // according to
+ // FileEnumerator's algorithm. We test this by writing out some files and
+ // validating what is matched.
+
+ base::ScopedTempDir temp_dir;
+ ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+ base::FilePath user_data_dir = temp_dir.GetPath();
+
+ // Create the stability directory.
+ base::FilePath stability_dir = GetStabilityDir(user_data_dir);
+ ASSERT_TRUE(base::CreateDirectory(stability_dir));
+
+ // Write a stability file.
+ base::FilePath stability_file;
+ ASSERT_TRUE(GetStabilityFileForProcess(base::Process::Current(),
+ user_data_dir, &stability_file));
+ {
+ base::ScopedFILE file(base::OpenFile(stability_file, "w"));
+ ASSERT_TRUE(file.get());
+ }
+
+ // Write a file that shouldn't match.
+ base::FilePath non_matching_file =
+ stability_dir.AppendASCII("non_matching.foo");
+ {
+ base::ScopedFILE file(base::OpenFile(non_matching_file, "w"));
+ ASSERT_TRUE(file.get());
+ }
+
+ // Validate only the stability file matches.
+ base::FileEnumerator enumerator(stability_dir, false /* recursive */,
+ base::FileEnumerator::FILES,
+ GetStabilityFilePattern());
+ ASSERT_EQ(stability_file, enumerator.Next());
+ ASSERT_TRUE(enumerator.Next().empty());
+}
+
TEST(StabilityPathsTest, GetStabilityFiles) {
base::ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
« no previous file with comments | « components/browser_watcher/stability_debugging_win_unittest.cc ('k') | components/browser_watcher/stability_report.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698