WebUI: Move test_browser_proxy.js one level up.

chrome/test/data/webui/test_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-cr.define('settings', function() {
+cr.define('test', function() {

[Dan Beam, 2017/06/07 01:16:57]

why test.Test?

[dpapad, 2017/06/07 01:19:10]

As opposed to what? A different namespace? No namespace? I think having a
namespace is better than adding yet another global. 'test' seemed appropriate.

[Dan Beam, 2017/06/07 01:33:50]

arguably, this is "testing" code.  as in: it's not a test; you're not testing
the browser proxy.  you're using it in a supporting role, which I often see
"testing" used for.

note the subtle distinction in gtest:
https://cs.chromium.org/chromium/src/third_party/googletest/src/googletest/in...

it's in a "testing" namespace, but the base class is a "test".

i get that it's a "TestBrowserProxy" instead of a "BrowserProxyTest", but just
general nit.

additionally, I just also have an issue with redundant prefixes.  I don't think
having 2 x "test" in the identifier adds any information, it just makes things
longer.

I (personally) would just remove the cr.define() wrapper.

this means:
a) no redundant "test" or "testing" namespace (and no need to decide which one)
b) no dependency on cr.js (which otherwise this file doesn't use, it does rely
on promise_resolver.js, though)

[dpapad, 2017/06/07 03:23:08]

Done.

   /**
    * A base class for all test browser proxies to inherit from. Provides helper
    * methods for allowing tests to track when a method was called.
    *
    * Subclasses are responsible for calling |methodCalled|, when a method is
    * called, which will trigger callers of |whenCalled| to get notified.
    * For example:
    * --------------------------------------------------------------------------
    * var MyTestBrowserProxy = function() {
    *   TestBrowserProxy.call(this, ['myMethod']);
@@ skipping 64 matching lines @@
       this.resolverMap_.forEach(function(value, methodName) {
         this.resolverMap_.set(methodName, new PromiseResolver());
       }.bind(this));
     },
   };
 
   return {
     TestBrowserProxy: TestBrowserProxy,
   };
 });