Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2657)

Unified Diff: pkg/kernel/lib/target/targets.dart

Issue 2927613002: Improve NSM handling. (Closed)
Patch Set: Address review comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/target/flutter.dart ('k') | pkg/kernel/lib/target/vm.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/target/targets.dart
diff --git a/pkg/kernel/lib/target/targets.dart b/pkg/kernel/lib/target/targets.dart
index a9c96f252b1821d7c5a95c0406811d871e89349c..57fdd758da872d77702906cb4bf3c344fb64cd8d 100644
--- a/pkg/kernel/lib/target/targets.dart
+++ b/pkg/kernel/lib/target/targets.dart
@@ -114,9 +114,22 @@ abstract class Target {
/// Builds an expression that instantiates an [Invocation] that can be passed
/// to [noSuchMethod].
- Expression instantiateInvocation(Member target, Expression receiver,
+ Expression instantiateInvocation(CoreTypes coreTypes, Expression receiver,
String name, Arguments arguments, int offset, bool isSuper);
+ Expression instantiateNoSuchMethodError(CoreTypes coreTypes,
+ Expression receiver, String name, Arguments arguments, int offset,
+ {bool isMethod: false,
+ bool isGetter: false,
+ bool isSetter: false,
+ bool isField: false,
+ bool isLocalVariable: false,
+ bool isDynamic: false,
+ bool isSuper: false,
+ bool isStatic: false,
+ bool isConstructor: false,
+ bool isTopLevel: false});
+
String toString() => 'Target($name)';
}
@@ -135,8 +148,24 @@ class NoneTarget extends Target {
{void logger(String msg)}) {}
@override
- Expression instantiateInvocation(Member target, Expression receiver,
+ Expression instantiateInvocation(CoreTypes coreTypes, Expression receiver,
String name, Arguments arguments, int offset, bool isSuper) {
return new InvalidExpression();
}
+
+ @override
+ Expression instantiateNoSuchMethodError(CoreTypes coreTypes,
+ Expression receiver, String name, Arguments arguments, int offset,
+ {bool isMethod: false,
+ bool isGetter: false,
+ bool isSetter: false,
+ bool isField: false,
+ bool isLocalVariable: false,
+ bool isDynamic: false,
+ bool isSuper: false,
+ bool isStatic: false,
+ bool isConstructor: false,
+ bool isTopLevel: false}) {
+ return new InvalidExpression();
+ }
}
« no previous file with comments | « pkg/kernel/lib/target/flutter.dart ('k') | pkg/kernel/lib/target/vm.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698