Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: pkg/front_end/lib/src/fasta/target_implementation.dart

Issue 2927613002: Improve NSM handling. (Closed)
Patch Set: Address review comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/source/source_loader.dart ('k') | pkg/front_end/test/fasta/compile.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/target_implementation.dart
diff --git a/pkg/front_end/lib/src/fasta/target_implementation.dart b/pkg/front_end/lib/src/fasta/target_implementation.dart
index dd69f1c122b4e50ab87ee0f3c2359b89a8ef045a..7a7f3b4ab1b99c7368e16bbf9d5cca3b8116618d 100644
--- a/pkg/front_end/lib/src/fasta/target_implementation.dart
+++ b/pkg/front_end/lib/src/fasta/target_implementation.dart
@@ -6,8 +6,6 @@ library fasta.target_implementation;
import 'package:kernel/target/targets.dart' as backend show Target;
-import 'package:kernel/ast.dart' show Arguments, Expression, Member;
-
import 'builder/builder.dart' show Builder, ClassBuilder, LibraryBuilder;
import 'parser/dart_vm_native.dart' as vm show skipNativeClause;
@@ -34,9 +32,7 @@ abstract class TargetImplementation extends Target {
Builder cachedCompileTimeError;
Builder cachedDuplicatedFieldInitializerError;
Builder cachedFallThroughError;
- Builder cachedInvocation;
Builder cachedNativeAnnotation;
- Builder cachedNoSuchMethodError;
TargetImplementation(Ticker ticker, this.uriTranslator, this.backendTarget)
: super(ticker);
@@ -101,21 +97,6 @@ abstract class TargetImplementation extends Target {
loader.coreLibrary.getConstructor("FallThroughError");
}
- /// Returns a reference to the constructor of [Invocation]. The
- /// constructor is expected to accept these arguments:
- ///
- /// String functionName,
- /// List argumentsDescriptor,
- /// List arguments,
- /// bool isSuperInvocation
- Builder getInvocation(Loader loader) {
- if (cachedInvocation != null) {
- return cachedInvocation;
- }
- return cachedInvocation = loader.coreLibrary
- .getConstructor("_InvocationMirror", bypassLibraryPrivacy: true);
- }
-
/// Returns a reference to the constructor used for creating `native`
/// annotations. The constructor is expected to accept a single argument of
/// type String, which is the name of the native method.
@@ -125,22 +106,6 @@ abstract class TargetImplementation extends Target {
return cachedNativeAnnotation = internal.getConstructor("ExternalName");
}
- /// Returns a reference to the constructor of [NoSuchMethodError] error. The
- /// constructor is expected to accept these arguments:
- ///
- /// Object receiver, // A class literal for static methods.
- /// Symbol memberName,
- /// int type, // [computeNoSuchMethodType](kernel/kernel_builder.dart).
- /// List positionalArguments,
- /// Map<Symbol, dynamic> namedArguments,
- Builder getNoSuchMethodError(Loader loader) {
- if (cachedNoSuchMethodError != null) {
- return cachedNoSuchMethodError;
- }
- return cachedNoSuchMethodError = loader.coreLibrary
- .getConstructor("NoSuchMethodError", constructorName: "_withType");
- }
-
void loadExtraRequiredLibraries(Loader loader) {
for (String uri in backendTarget.extraRequiredLibraries) {
loader.read(Uri.parse(uri), -1);
@@ -178,10 +143,4 @@ abstract class TargetImplementation extends Target {
}
}
}
-
- Expression instantiateInvocation(Member target, Expression receiver,
- String name, Arguments arguments, int offset, bool isSuper) {
- return backendTarget.instantiateInvocation(
- target, receiver, name, arguments, offset, isSuper);
- }
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/source/source_loader.dart ('k') | pkg/front_end/test/fasta/compile.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698