Issue 2927603003: Add a mixin to handle analysis.getNavigation requests

Issue 2927603003: Add a mixin to handle analysis.getNavigation requests (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson

Modified:
3 years, 6 months ago

Reviewers:
mfairhurst

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -0 lines)			Patch
	A	pkg/analyzer_plugin/lib/plugin/navigation_mixin.dart	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download
	M	pkg/analyzer_plugin/lib/utilities/navigation/navigation.dart	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

mfairhurst

LGTM -- only quirk I'm not sure about is the ResolveResult once again. But I ...

3 years, 6 months ago (2017-06-06 20:04:41 UTC) #3

Brian Wilkerson

Except that I missed the fact that the generator method I used created notifications, but ...

3 years, 6 months ago (2017-06-06 20:35:57 UTC) #4

mfairhurst

Ah, yes, I see! (Though I don't know what PTAL is). LGTM

3 years, 6 months ago (2017-06-06 20:44:07 UTC) #5

Brian Wilkerson

3 years, 6 months ago (2017-06-06 21:13:06 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
689436491769ebae7a84dd34978efc04bb7de695 (presubmit successful).