Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: components/metrics/child_call_stack_profile_collector.h

Issue 2927593002: Make stack sampling profiler sample beyond startup. (Closed)
Patch Set: Remove debug log statements. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/child_call_stack_profile_collector.h
diff --git a/components/metrics/child_call_stack_profile_collector.h b/components/metrics/child_call_stack_profile_collector.h
index 7eb3abae8146517dc7863d49f8c77b9d3fee59ff..5cf08794fb6dd8c67a9a95af8ed820858f349147 100644
--- a/components/metrics/child_call_stack_profile_collector.h
+++ b/components/metrics/child_call_stack_profile_collector.h
@@ -5,6 +5,8 @@
#ifndef COMPONENTS_METRICS_CHILD_CALL_STACK_PROFILE_COLLECTOR_H_
#define COMPONENTS_METRICS_CHILD_CALL_STACK_PROFILE_COLLECTOR_H_
+#include <vector>
+
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/single_thread_task_runner.h"
@@ -90,9 +92,14 @@ class ChildCallStackProfileCollector {
using CallStackProfile = base::StackSamplingProfiler::CallStackProfile;
- void Collect(const CallStackProfileParams& params,
- base::TimeTicks start_timestamp,
- std::vector<CallStackProfile> profiles);
+ base::Optional<base::StackSamplingProfiler::SamplingParams> Collect(
+ const CallStackProfileParams& params,
+ base::TimeTicks start_timestamp,
+ std::vector<CallStackProfile> profiles);
+
+ void CollectImpl(const CallStackProfileParams& params,
+ base::TimeTicks start_timestamp,
+ std::vector<CallStackProfile> profiles);
// This object may be accessed on any thread, including the profiler
// thread. The expected use case for the object is to be created and have
« no previous file with comments | « components/metrics/call_stack_profile_params.cc ('k') | components/metrics/child_call_stack_profile_collector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698