Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5017)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2927593002: Make stack sampling profiler sample beyond startup. (Closed)
Patch Set: fix some lint warnings Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.h ('k') | components/metrics/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 79321911137b1aed54eb25bf6475ddc0e01cced5..a731af075cdeadc7767943a58129fe2171f469e9 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -630,16 +630,17 @@ ChromeBrowserMainParts::ChromeBrowserMainParts(
result_code_(content::RESULT_CODE_NORMAL_EXIT),
startup_watcher_(new StartupTimeBomb()),
shutdown_watcher_(new ShutdownWatcherHelper()),
+ sampling_profiler_params_(
+ metrics::CallStackProfileParams::BROWSER_PROCESS,
+ metrics::CallStackProfileParams::UI_THREAD,
+ metrics::CallStackProfileParams::PROCESS_STARTUP,
+ metrics::CallStackProfileParams::MAY_SHUFFLE),
sampling_profiler_(
base::PlatformThread::CurrentId(),
- StackSamplingConfiguration::Get()->
- GetSamplingParamsForCurrentProcess(),
+ StackSamplingConfiguration::Get()
+ ->GetSamplingParamsForCurrentProcess(),
metrics::CallStackProfileMetricsProvider::GetProfilerCallback(
- metrics::CallStackProfileParams(
- metrics::CallStackProfileParams::BROWSER_PROCESS,
- metrics::CallStackProfileParams::UI_THREAD,
- metrics::CallStackProfileParams::PROCESS_STARTUP,
- metrics::CallStackProfileParams::MAY_SHUFFLE))),
+ &sampling_profiler_params_)),
sky 2017/07/12 21:42:58 It's rather error prone to have callers be respons
Alexei Svitkine (slow) 2017/07/13 17:58:22 Done.
profile_(NULL),
run_message_loop_(true),
local_state_(NULL) {
« no previous file with comments | « chrome/browser/chrome_browser_main.h ('k') | components/metrics/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698