Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: vpython/spec/spec_test.go

Issue 2927573002: [vpython] Fix PEP425 naming. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The LUCI Authors. All rights reserved. 1 // Copyright 2017 The LUCI Authors. All rights reserved.
2 // Use of this source code is governed under the Apache License, Version 2.0 2 // Use of this source code is governed under the Apache License, Version 2.0
3 // that can be found in the LICENSE file. 3 // that can be found in the LICENSE file.
4 4
5 package spec 5 package spec
6 6
7 import ( 7 import (
8 "testing" 8 "testing"
9 9
10 "github.com/luci/luci-go/vpython/api/vpython" 10 "github.com/luci/luci-go/vpython/api/vpython"
(...skipping 24 matching lines...) Expand all
35 Convey(`With a non-nil spec`, func() { 35 Convey(`With a non-nil spec`, func() {
36 env.Spec = &vpython.Spec{} 36 env.Spec = &vpython.Spec{}
37 37
38 Convey(`Will normalize to sorted order.`, func() { 38 Convey(`Will normalize to sorted order.`, func() {
39 env.Spec.Wheel = []*vpython.Spec_Package{pkgFoo, pkgBar, pkgBaz} 39 env.Spec.Wheel = []*vpython.Spec_Package{pkgFoo, pkgBar, pkgBaz}
40 So(NormalizeEnvironment(&env), ShouldBeNil) 40 So(NormalizeEnvironment(&env), ShouldBeNil)
41 So(env.Spec, ShouldResemble, &vpython.Spec{ 41 So(env.Spec, ShouldResemble, &vpython.Spec{
42 Wheel: []*vpython.Spec_Package{pkgBar, p kgBaz, pkgFoo}, 42 Wheel: []*vpython.Spec_Package{pkgBar, p kgBaz, pkgFoo},
43 }) 43 })
44 44
45 » » » » So(Hash(env.Spec, &rt, ""), ShouldEqual, "7e80b8 643051ce0d82bf44fb180687e988791cfd7f3da39861370f0a56fc80f8") 45 » » » » So(Hash(env.Spec, &rt, ""), ShouldEqual, "1e32c0 2610b51f8c3807203fccd3e8d01d252868d52eb4ee9df135ef6533c5ae")
46 » » » » So(Hash(env.Spec, &rt, "extra"), ShouldEqual, "1 40a02bb88b011d4aceafb9533266288fd4b441c3bdb70494419b3ef76457f34") 46 » » » » So(Hash(env.Spec, &rt, "extra"), ShouldEqual, "d 047eb021f50534c050aaa10c70dc7b4a9b511fab00cf67a191b2b0805f24420")
47 }) 47 })
48 48
49 Convey(`Will fail to normalize if there are duplicate wh eels.`, func() { 49 Convey(`Will fail to normalize if there are duplicate wh eels.`, func() {
50 env.Spec.Wheel = []*vpython.Spec_Package{pkgFoo, pkgFoo, pkgBar, pkgBaz} 50 env.Spec.Wheel = []*vpython.Spec_Package{pkgFoo, pkgFoo, pkgBar, pkgBaz}
51 So(NormalizeEnvironment(&env), ShouldErrLike, "d uplicate spec entries") 51 So(NormalizeEnvironment(&env), ShouldErrLike, "d uplicate spec entries")
52 52
53 // Even if the versions differ. 53 // Even if the versions differ.
54 fooClone := *pkgFoo 54 fooClone := *pkgFoo
55 fooClone.Version = "other" 55 fooClone.Version = "other"
56 env.Spec.Wheel = []*vpython.Spec_Package{pkgFoo, &fooClone, pkgBar, pkgBaz} 56 env.Spec.Wheel = []*vpython.Spec_Package{pkgFoo, &fooClone, pkgBar, pkgBaz}
57 So(NormalizeEnvironment(&env), ShouldErrLike, "d uplicate spec entries") 57 So(NormalizeEnvironment(&env), ShouldErrLike, "d uplicate spec entries")
58 }) 58 })
59 }) 59 })
60 }) 60 })
61 } 61 }
OLDNEW
« vpython/cipd/pep425.go ('K') | « vpython/spec/spec.go ('k') | vpython/venv/venv.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698