Issue 2927523002: Replace ClosedWorldClassHierarchy with IncrementalClassHierarchy in SourceLoader.

Issue 2927523002: Replace ClosedWorldClassHierarchy with IncrementalClassHierarchy in SourceLoader. (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Replace ClosedWorldClassHierarchy with IncrementalClassHierarchy in SourceLoader. This does not cause any measurable performance changes for Fasta. This speeds up initial compilation using Kernel Driver from 16 seconds to about 7.6 seconds. Just using Fasta takes 7 seconds, so Kernel Driver is just about 10% slower now. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a0fb4d9aefaf5fd86a8da4d79a568ebe95f20242

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	pkg/front_end/lib/src/fasta/source/source_loader.dart	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 7 (1 generated)

scheglov

On 2017/06/06 10:18:07, ahe wrote: > lgtm > > Compiling what? pkg/analyzer_cli/bin/analyzer.dart

3 years, 6 months ago (2017-06-06 14:04:01 UTC) #4

scheglov

3 years, 6 months ago (2017-06-06 19:38:37 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a0fb4d9aefaf5fd86a8da4d79a568ebe95f20242 (presubmit successful).