Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4489)

Unified Diff: chrome/common/media_router/media_source_helper_unittest.cc

Issue 2927503002: [Presentation API / Media Router] Relax PresentationRequest URL check. (Closed)
Patch Set: Really add #include Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/media_router/media_source_helper.cc ('k') | chrome/test/media_router/resources/common.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/media_router/media_source_helper_unittest.cc
diff --git a/chrome/common/media_router/media_source_helper_unittest.cc b/chrome/common/media_router/media_source_helper_unittest.cc
index 318912c351b38ce1e987b50d6aae50ebedbe4911..b6f3fa321b45ce57b28cdfbd770bcb69567bf1dc 100644
--- a/chrome/common/media_router/media_source_helper_unittest.cc
+++ b/chrome/common/media_router/media_source_helper_unittest.cc
@@ -46,6 +46,15 @@ TEST(MediaSourcesTest, IsValidMediaSource) {
MediaSourceForPresentationUrl(GURL("totally not a url"))));
}
+TEST(MediaSourcesTest, IsValidPresentationUrl) {
+ EXPECT_FALSE(IsValidPresentationUrl(GURL()));
+ EXPECT_FALSE(IsValidPresentationUrl(GURL("unsupported-scheme://foo")));
+
+ EXPECT_TRUE(IsValidPresentationUrl(GURL("https://google.com")));
+ EXPECT_TRUE(IsValidPresentationUrl(GURL("cast://foo")));
+ EXPECT_TRUE(IsValidPresentationUrl(GURL("cast:foo")));
+}
+
TEST(MediaSourcesTest, CanConnectToMediaSource) {
EXPECT_TRUE(CanConnectToMediaSource(
MediaSource(GURL("https://google.com/cast#__castAppId__=233637DE"))));
« no previous file with comments | « chrome/common/media_router/media_source_helper.cc ('k') | chrome/test/media_router/resources/common.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698