Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 2927503002: [Presentation API / Media Router] Relax PresentationRequest URL check. (Closed)
Patch Set: Really add #include Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h" 5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/test/mock_callback.h" 8 #include "base/test/mock_callback.h"
9 #include "chrome/browser/media/router/mock_media_router.h" 9 #include "chrome/browser/media/router/mock_media_router.h"
10 #include "chrome/browser/media/router/mock_screen_availability_listener.h" 10 #include "chrome/browser/media/router/mock_screen_availability_listener.h"
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 EXPECT_TRUE(delegate_impl_->HasScreenAvailabilityListenerForTest( 313 EXPECT_TRUE(delegate_impl_->HasScreenAvailabilityListenerForTest(
314 main_frame_process_id_, main_frame_routing_id_, source1_.id())); 314 main_frame_process_id_, main_frame_routing_id_, source1_.id()));
315 315
316 EXPECT_CALL(router_, UnregisterMediaSinksObserver(_)).Times(1); 316 EXPECT_CALL(router_, UnregisterMediaSinksObserver(_)).Times(1);
317 delegate_impl_->RemoveScreenAvailabilityListener( 317 delegate_impl_->RemoveScreenAvailabilityListener(
318 main_frame_process_id_, main_frame_routing_id_, &listener1_); 318 main_frame_process_id_, main_frame_routing_id_, &listener1_);
319 EXPECT_FALSE(delegate_impl_->HasScreenAvailabilityListenerForTest( 319 EXPECT_FALSE(delegate_impl_->HasScreenAvailabilityListenerForTest(
320 main_frame_process_id_, main_frame_routing_id_, source1_.id())); 320 main_frame_process_id_, main_frame_routing_id_, source1_.id()));
321 } 321 }
322 322
323 TEST_F(PresentationServiceDelegateImplTest, AddListenerForInvalidUrl) {
324 MockScreenAvailabilityListener listener(GURL("unsupported-url://foo"));
325 EXPECT_CALL(listener, OnScreenAvailabilityChanged(false));
326 EXPECT_FALSE(delegate_impl_->AddScreenAvailabilityListener(
327 main_frame_process_id_, main_frame_routing_id_, &listener));
328 EXPECT_CALL(router_, RegisterMediaSinksObserver(_)).Times(0);
329 }
330
323 // TODO(imcheng): Add a test to set default presentation URL in a different 331 // TODO(imcheng): Add a test to set default presentation URL in a different
324 // RenderFrameHost and verify that it is ignored. 332 // RenderFrameHost and verify that it is ignored.
325 TEST_F(PresentationServiceDelegateImplTest, SetDefaultPresentationUrl) { 333 TEST_F(PresentationServiceDelegateImplTest, SetDefaultPresentationUrl) {
326 EXPECT_FALSE(delegate_impl_->HasDefaultPresentationRequest()); 334 EXPECT_FALSE(delegate_impl_->HasDefaultPresentationRequest());
327 335
328 GURL frame_url(kFrameUrl); 336 GURL frame_url(kFrameUrl);
329 content::WebContentsTester::For(GetWebContents()) 337 content::WebContentsTester::For(GetWebContents())
330 ->NavigateAndCommit(frame_url); 338 ->NavigateAndCommit(frame_url);
331 339
332 auto callback = base::Bind( 340 auto callback = base::Bind(
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
727 base::Bind(&MockCreatePresentationConnnectionCallbacks:: 735 base::Bind(&MockCreatePresentationConnnectionCallbacks::
728 OnCreateConnectionSuccess, 736 OnCreateConnectionSuccess,
729 base::Unretained(&mock_create_connection_callbacks)), 737 base::Unretained(&mock_create_connection_callbacks)),
730 base::Bind( 738 base::Bind(
731 &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError, 739 &MockCreatePresentationConnnectionCallbacks::OnCreateConnectionError,
732 base::Unretained(&mock_create_connection_callbacks))); 740 base::Unretained(&mock_create_connection_callbacks)));
733 } 741 }
734 #endif // !defined(OS_ANDROID) 742 #endif // !defined(OS_ANDROID)
735 743
736 } // namespace media_router 744 } // namespace media_router
OLDNEW
« no previous file with comments | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | chrome/common/media_router/media_source_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698