Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2927493002: Restructure code to enable reloading when a kernel dill file is specified on the command line inste… (Closed)

Created:
3 years, 6 months ago by siva
Modified:
3 years, 6 months ago
Reviewers:
aam
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

1. Restructure code to enable reloading when a kernel dill file is specified on the command line instead of sources. 2. Read the platform dill file at startup not for every isolate creation 3. Store the memory representation of kernel program in isolate data so that it is deleted when the isolate is shutdown R=aam@google.com Committed: https://github.com/dart-lang/sdk/commit/6656404ad6b98c3e9be255ac7ee23d47da8664bc

Patch Set 1 #

Patch Set 2 : Fix build error. #

Patch Set 3 : fix format error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -97 lines) Patch
M runtime/bin/dfe.h View 1 2 chunks +22 lines, -2 lines 0 comments Download
M runtime/bin/dfe.cc View 1 3 chunks +61 lines, -8 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 3 chunks +11 lines, -19 lines 0 comments Download
M runtime/bin/isolate_data.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/isolate_data.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/bin/loader.cc View 1 chunk +15 lines, -14 lines 0 comments Download
M runtime/bin/main.cc View 1 6 chunks +33 lines, -54 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
siva
3 years, 6 months ago (2017-06-06 01:37:37 UTC) #4
aam
lgtm!
3 years, 6 months ago (2017-06-06 01:58:08 UTC) #5
siva
3 years, 6 months ago (2017-06-07 20:42:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6656404ad6b98c3e9be255ac7ee23d47da8664bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698