Issue 2927463003: Compute all canonical names only for libraries being serialized.

Issue 2927463003: Compute all canonical names only for libraries being serialized. (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Kevin Millikin (Google), Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Compute all canonical names only for libraries being serialized. This makes compilation with Kernel Driver about 20% faster than Fasta, about 5.8 seconds using Kernel Driver vs. 7.2 seconds using Fasta. Note that this is initial compilation, i.e. nothing read from the cache yet. R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c569a4a8b8c2035fde53a7d8ff2c2f8694a79794

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -2 lines)			Patch
M	pkg/front_end/lib/src/incremental_kernel_generator_impl.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/kernel/lib/binary/ast_to_binary.dart	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	pkg/kernel/lib/binary/limited_ast_to_binary.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

Paul Berry

lgtm, but wait for approval from one of the other reviewers before committing

3 years, 6 months ago (2017-06-06 21:09:44 UTC) #2

ahe

LGTM, but it doesn't make sense that Kernel Driver is faster than Fasta. If Kernel ...

3 years, 6 months ago (2017-06-07 06:54:28 UTC) #4

scheglov

3 years, 6 months ago (2017-06-07 15:50:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c569a4a8b8c2035fde53a7d8ff2c2f8694a79794 (presubmit successful).