Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4696)

Unified Diff: chrome/browser/net/nqe/ui_network_quality_estimator_service.cc

Issue 2927453002: Make NQE a derived class of NetworkQualityProvider (Closed)
Patch Set: some more IWYU fixes Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/nqe/ui_network_quality_estimator_service.cc
diff --git a/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc b/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc
index a13b2c3c923728f4fcff1c0bebea37c7caa44c46..a118d4e7f3eca2289d321c65b4c4dede1e1e0193 100644
--- a/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc
+++ b/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc
@@ -20,8 +20,10 @@
#include "components/prefs/pref_service.h"
#include "components/variations/variations_associated_data.h"
#include "content/public/browser/browser_thread.h"
+#include "net/nqe/effective_connection_type_observer.h"
#include "net/nqe/network_qualities_prefs_manager.h"
#include "net/nqe/network_quality.h"
+#include "net/nqe/rtt_throughput_estimates_observer.h"
namespace {
@@ -81,8 +83,8 @@ void SetNQEOnIOThread(net::NetworkQualitiesPrefsManager* prefs_manager,
// to the UI service.
// It is created on the UI thread, but used and deleted on the IO thread.
class UINetworkQualityEstimatorService::IONetworkQualityObserver
- : public net::NetworkQualityEstimator::EffectiveConnectionTypeObserver,
- public net::NetworkQualityEstimator::RTTAndThroughputEstimatesObserver {
+ : public net::EffectiveConnectionTypeObserver,
+ public net::RTTAndThroughputEstimatesObserver {
public:
explicit IONetworkQualityObserver(
base::WeakPtr<UINetworkQualityEstimatorService> service)
@@ -221,7 +223,7 @@ void UINetworkQualityEstimatorService::RTTOrThroughputComputed(
}
void UINetworkQualityEstimatorService::AddEffectiveConnectionTypeObserver(
- net::NetworkQualityEstimator::EffectiveConnectionTypeObserver* observer) {
+ net::EffectiveConnectionTypeObserver* observer) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
effective_connection_type_observer_list_.AddObserver(observer);
@@ -235,7 +237,7 @@ void UINetworkQualityEstimatorService::AddEffectiveConnectionTypeObserver(
}
void UINetworkQualityEstimatorService::RemoveEffectiveConnectionTypeObserver(
- net::NetworkQualityEstimator::EffectiveConnectionTypeObserver* observer) {
+ net::EffectiveConnectionTypeObserver* observer) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
effective_connection_type_observer_list_.RemoveObserver(observer);
}
@@ -268,7 +270,7 @@ UINetworkQualityEstimatorService::GetDownstreamThroughputKbps() const {
}
void UINetworkQualityEstimatorService::AddRTTAndThroughputEstimatesObserver(
- net::NetworkQualityEstimator::RTTAndThroughputEstimatesObserver* observer) {
+ net::RTTAndThroughputEstimatesObserver* observer) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
rtt_throughput_observer_list_.AddObserver(observer);
@@ -284,7 +286,7 @@ void UINetworkQualityEstimatorService::AddRTTAndThroughputEstimatesObserver(
// Removes |observer| from the list of RTT and throughput estimate observers.
// Must be called on the IO thread.
void UINetworkQualityEstimatorService::RemoveRTTAndThroughputEstimatesObserver(
- net::NetworkQualityEstimator::RTTAndThroughputEstimatesObserver* observer) {
+ net::RTTAndThroughputEstimatesObserver* observer) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
rtt_throughput_observer_list_.RemoveObserver(observer);
}
@@ -310,8 +312,7 @@ void UINetworkQualityEstimatorService::ClearPrefs() {
void UINetworkQualityEstimatorService::
NotifyEffectiveConnectionTypeObserverIfPresent(
- net::NetworkQualityEstimator::EffectiveConnectionTypeObserver* observer)
- const {
+ net::EffectiveConnectionTypeObserver* observer) const {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (!effective_connection_type_observer_list_.HasObserver(observer))
@@ -322,8 +323,7 @@ void UINetworkQualityEstimatorService::
}
void UINetworkQualityEstimatorService::NotifyRTTAndThroughputObserverIfPresent(
- net::NetworkQualityEstimator::RTTAndThroughputEstimatesObserver* observer)
- const {
+ net::RTTAndThroughputEstimatesObserver* observer) const {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (!rtt_throughput_observer_list_.HasObserver(observer))

Powered by Google App Engine
This is Rietveld 408576698