Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292743017: Cleanup: Use base::CommandLine in mojo/ (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Cleanup: Use base::CommandLine in mojo/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272712

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M mojo/common/test/multiprocess_test_helper.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/embedder/platform_channel_pair_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/embedder/platform_channel_pair_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/dbus_echo/dbus_echo_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/android/mojo_main.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/child_process.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/child_process_host.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/shell/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/dynamic_service_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/run.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/shell/shell_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-22 20:56:27 UTC) #1
viettrungluu
lgtm
6 years, 7 months ago (2014-05-22 21:16:40 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-22 22:19:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/292743017/20001
6 years, 7 months ago (2014-05-22 22:22:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 06:06:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 07:52:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/31933)
6 years, 7 months ago (2014-05-23 07:52:26 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-24 06:34:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/292743017/20001
6 years, 7 months ago (2014-05-24 06:35:02 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 12:20:18 UTC) #10
Message was sent while issue was closed. 
Change committed as 272712

Powered by Google App Engine
This is Rietveld 408576698