Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 292743011: Pepper: Simplify Pnacl manifest id logic. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Simplify Pnacl manifest id logic. This removes some unnecessary manifest_id storage and passing to make manifest behavior clearer in the trusted plugin. Helper NaCl Modules (llc and ld) always use the "Pnacl Manifest" for resolving keys, as there is no relevant json-formatted NMF available. BUG=239656 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272582

Patch Set 1 : #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 1 5 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
teravest
6 years, 7 months ago (2014-05-21 23:38:02 UTC) #1
dmichael (off chromium)
lgtm
6 years, 7 months ago (2014-05-23 15:55:11 UTC) #2
teravest
6 years, 7 months ago (2014-05-23 20:12:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r272582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698