Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 292743006: Blink GC plugin: disallow GC derived types as part-object fields. (Closed)

Created:
6 years, 7 months ago by zerny-chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews, oilpan-reviews
Visibility:
Public.

Description

Blink GC plugin: disallow GC derived types as part-object fields. BUG=334149 R=ager@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271880

Patch Set 1 #

Patch Set 2 : support for mixin part objects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -31 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 10 chunks +67 lines, -24 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/part_object_to_gc_derived_class.h View 1 chunk +6 lines, -5 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/part_object_to_gc_derived_class.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
A tools/clang/blink_gc_plugin/tests/part_object_to_gc_derived_class.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
zerny-chromium
6 years, 7 months ago (2014-05-20 11:21:46 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 7 months ago (2014-05-20 11:29:45 UTC) #2
wibling-chromium
lgtm
6 years, 7 months ago (2014-05-20 11:32:17 UTC) #3
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-20 11:54:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/292743006/1
6 years, 7 months ago (2014-05-20 11:54:58 UTC) #5
haraken
LGTM
6 years, 7 months ago (2014-05-20 12:08:00 UTC) #6
zerny-chromium
The CQ bit was unchecked by zerny@chromium.org
6 years, 7 months ago (2014-05-20 13:38:45 UTC) #7
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-21 10:58:03 UTC) #8
zerny-chromium
The CQ bit was unchecked by zerny@chromium.org
6 years, 7 months ago (2014-05-21 10:58:25 UTC) #9
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-21 11:43:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/292743006/20001
6 years, 7 months ago (2014-05-21 11:44:08 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 11:47:01 UTC) #12
Message was sent while issue was closed.
Change committed as 271880

Powered by Google App Engine
This is Rietveld 408576698