Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Issue 292743005: Add timeout for usb charging commands. (Closed)

Created:
6 years, 7 months ago by qsr
Modified:
6 years, 7 months ago
Reviewers:
tonyg
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add timeout for usb charging commands. Also check that we are root, as non rooted cannot control usb charging. BUG=375178 R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271670

Patch Set 1 #

Patch Set 2 : Adding check for root. #

Patch Set 3 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/android/pylib/android_commands.py View 1 2 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qsr
6 years, 7 months ago (2014-05-20 11:06:58 UTC) #1
tonyg
lgtm
6 years, 7 months ago (2014-05-20 11:39:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/292743005/40001
6 years, 7 months ago (2014-05-20 11:40:26 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 13:12:47 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 15:56:37 UTC) #5
Message was sent while issue was closed.
Change committed as 271670

Powered by Google App Engine
This is Rietveld 408576698