Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2927343002: Prioritize required name param completions (flutter-intellij#1049). (Closed)

Created:
3 years, 6 months ago by pquitslund
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 3 chunks +18 lines, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/utilities/completion/relevance.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
See: https://github.com/flutter/flutter-intellij/issues/1049 for screenshot. :)
3 years, 6 months ago (2017-06-09 17:11:02 UTC) #2
danrubel
On 2017/06/09 17:11:02, pquitslund wrote: > See: https://github.com/flutter/flutter-intellij/issues/1049 for screenshot. :) LGTM
3 years, 6 months ago (2017-06-09 17:14:15 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as b502bb69562692533214d804963dd99ade57d594 (presubmit successful).
3 years, 6 months ago (2017-06-09 17:20:22 UTC) #5
Brian Wilkerson
3 years, 6 months ago (2017-06-09 17:20:37 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698