Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2927303003: Add hooks to allow lock screen app pages in sign-in profile (Closed)

Created:
3 years, 6 months ago by tbarzic
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add hooks to allow lock screen app pages in sign-in profile * enable extensions in sign-in profile if lock screen apps are enabled * allow background pages in sign-in profile for apps with lockScreen permission Also, adds browser tests for launching note taking action on lock screen. BUG=715781 [landed in another cl]

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -0 lines) Patch
A chrome/browser/chromeos/lock_screen_apps/note_taking_browsertest.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_process_manager_delegate.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/lock_screen_apps/app_launch/background.js View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/lock_screen_apps/app_launch/manifest.json View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/lock_screen_apps/app_launch/test.html View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/lock_screen_apps/app_launch/test.js View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/lock_screen_apps/non_lock_screen_context/app.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/lock_screen_apps/non_lock_screen_context/background.js View 1 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/lock_screen_apps/non_lock_screen_context/manifest.json View 1 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2934513003 Patch 20001

Messages

Total messages: 5 (5 generated)
tbarzic
The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-14 03:28:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927303003/20001
3 years, 6 months ago (2017-06-14 03:29:15 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-14 04:41:59 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 6 months ago (2017-06-14 04:42:00 UTC) #4
tbarzic
3 years, 5 months ago (2017-07-13 03:36:47 UTC) #5 
Description was changed from

==========
Add hooks to allow lock screen app pages in sign-in profile

* enable extensions in sign-in profile if lock screen apps are enabled
* allow background pages in sign-in profile for apps with lockScreen
  permission

Also, adds browser tests for launching note taking action on lock screen.

BUG=715781
==========

to

==========
Add hooks to allow lock screen app pages in sign-in profile

* enable extensions in sign-in profile if lock screen apps are enabled
* allow background pages in sign-in profile for apps with lockScreen
  permission

Also, adds browser tests for launching note taking action on lock screen.

BUG=715781

[landed in another cl]
==========

Powered by Google App Engine
This is Rietveld 408576698