Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 29273005: CanvasRenderingContext2D.fillText now works correctly with null maxWidth. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Better style + better tests. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index adc5b0e63c457ac6934ca8fb365dfcb3e65b0823..fa09c2b3eb05099f4f1a2cd10dd7c4c3b08d9fe0 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -2084,8 +2084,23 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {
// TODO(amouravski): Add Dartium native methods for drawImage once we figure
// out how to not break native bindings.
-}
+ /**
+ * Draws text to the canvas.
+ *
+ * The text is drawn starting at coordinates ([x], [y]).
+ * If [maxWidth] is provided and the [text] is computed to be wider than
+ * [maxWidth], then the drawn text is scaled down horizontally to fit.
+ *
+ * The text uses the current [CanvasRenderingContext2D.font] property for font
+ * options, such as typeface and size, and the current
+ * [CanvasRenderingContext2D.fillStyle] for style options such as color.
+ * The current [CanvasRenderingContext2D.textAlign] and
+ * [CanvasRenderingContext2D.textBaseLine] properties are also applied to the
+ * drawn text.
+ */
+ @DomName('CanvasRenderingContext2D.fillText')
+}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -35336,6 +35351,8 @@ class _Utils {
static bool isMap(obj) => obj is Map;
+ static List toListIfIterable(obj) => obj is Iterable ? obj.toList() : null;
+
static Map createMap() => {};
static makeUnimplementedError(String fileName, int lineNo) {
@@ -35642,10 +35659,6 @@ class _Utils {
static bool isNoSuchMethodError(obj) => obj is NoSuchMethodError;
- // TODO(jacobr): we need a failsafe way to determine that a Node is really a
- // DOM node rather than just a class that extends Node.
- static bool isNode(obj) => obj is Node;
-
static bool _isBuiltinType(ClassMirror cls) {
// TODO(vsm): Find a less hackish way to do this.
LibraryMirror lib = cls.owner;

Powered by Google App Engine
This is Rietveld 408576698