Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4101)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 2927273002: Move code for old, deprecated Options UI to only ChromeOS (Closed)
Patch Set: check_gn_headers Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index d0520ccedeee603b61aedd795a5801ac71e14e51..2d56788bd7adea872525edc1c1065b79ac6c21cc 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -43,7 +43,6 @@
#include "chrome/browser/ui/webui/net_internals/net_internals_ui.h"
#include "chrome/browser/ui/webui/ntp_tiles_internals_ui.h"
#include "chrome/browser/ui/webui/omnibox/omnibox_ui.h"
-#include "chrome/browser/ui/webui/options/options_ui.h"
#include "chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h"
#include "chrome/browser/ui/webui/physical_web/physical_web_ui.h"
#include "chrome/browser/ui/webui/policy_material_design_ui.h"
@@ -147,6 +146,7 @@
#include "chrome/browser/ui/webui/chromeos/sim_unlock_ui.h"
#include "chrome/browser/ui/webui/chromeos/slow_trace_ui.h"
#include "chrome/browser/ui/webui/chromeos/slow_ui.h"
+#include "chrome/browser/ui/webui/options/options_ui.h"
#include "chrome/browser/ui/webui/voice_search_ui.h"
#include "components/proximity_auth/webui/proximity_auth_ui.h"
#include "components/proximity_auth/webui/url_constants.h"
@@ -398,7 +398,7 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
extensions::ExtensionSystem::Get(profile)->extension_service()) {
return &NewWebUI<AppLauncherPageUI>;
}
-#endif // !defined(OS_CHROMEOS)
+#endif // defined(OS_CHROMEOS)
// Bookmarks are part of NTP on Android.
if (url.host_piece() == chrome::kChromeUIBookmarksHost) {
@@ -427,8 +427,6 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
url.host_piece() == chrome::kChromeUIMdSettingsHost) {
return &NewWebUI<settings::MdSettingsUI>;
}
- if (url.host_piece() == chrome::kChromeUISettingsFrameHost)
- return &NewWebUI<options::OptionsUI>;
// If the material design extensions page is enabled, it gets its own host.
// Otherwise, it's handled by the uber settings page.
if (url.host_piece() == chrome::kChromeUIExtensionsHost &&
@@ -483,6 +481,8 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
return &NewWebUI<chromeos::ProxySettingsUI>;
if (url.host_piece() == chrome::kChromeUISetTimeHost)
return &NewWebUI<chromeos::SetTimeUI>;
+ if (url.host_piece() == chrome::kChromeUISettingsFrameHost)
+ return &NewWebUI<options::OptionsUI>;
if (url.host_piece() == chrome::kChromeUISimUnlockHost)
return &NewWebUI<chromeos::SimUnlockUI>;
if (url.host_piece() == chrome::kChromeUISlowHost)

Powered by Google App Engine
This is Rietveld 408576698