Move code for old, deprecated Options UI to only ChromeOS

extensions/browser/api/runtime/runtime_apitest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/apps/app_browsertest_util.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "chrome/browser/extensions/test_extension_dir.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/test/browser_test_utils.h"
@@ skipping 80 matching lines @@
 
  private:
   base::ScopedTempDir scoped_temp_dir_;
   ScopedIgnoreContentVerifierForTest ignore_content_verification_;
 
   DISALLOW_COPY_AND_ASSIGN(RuntimeAPIUpdateTest);
 };
 
 }  // namespace
 
+#if defined(OS_CHROMEOS)

[Devlin, 2017/06/09 14:56:34]

Why?  This refers to the extensions options page, and the
runtime.openOptionsPage api is available on all platforms.

[Dan Beam, 2017/06/09 19:23:29]

yeah, sorry. leftovers from when opening the uber page would cause a test to
fail.  fixed that but forgot to unwrap.

 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeOpenOptionsPage) {
   ASSERT_TRUE(RunExtensionTest("runtime/open_options_page"));
 }
+#endif
 
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeOpenOptionsPageError) {
   ASSERT_TRUE(RunExtensionTest("runtime/open_options_page_error"));
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeGetPlatformInfo) {
   std::unique_ptr<base::Value> result(
       extension_function_test_utils::RunFunctionAndReturnSingleResult(
           new RuntimeGetPlatformInfoFunction(), "[]", browser()));
   ASSERT_TRUE(result.get() != NULL);
@@ skipping 95 matching lines @@
     ResultCatcher catcher;
     const int expected_change = 1;
     const Extension* extension_v2 =
         UpdateExtension(extension_id, data[1].crx_path, expected_change);
     ASSERT_TRUE(extension_v2);
     EXPECT_TRUE(catcher.GetNextResult());
   }
 }
 
 }  // namespace extensions