Move code for old, deprecated Options UI to only ChromeOS

chrome/browser/ui/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 195 matching lines @@
     "views/platform_keys_certificate_selector_chromeos.h",
     "web_contents_sizer.h",
     "webui/about_ui.cc",
     "webui/about_ui.h",
     "webui/bluetooth_internals/bluetooth_internals_ui.cc",
     "webui/bluetooth_internals/bluetooth_internals_ui.h",
     "webui/browsing_history_handler.cc",
     "webui/browsing_history_handler.h",
     "webui/chrome_web_ui_controller_factory.cc",
     "webui/chrome_web_ui_controller_factory.h",
-    "webui/chromeos/bluetooth_pairing_ui.cc",
-    "webui/chromeos/bluetooth_pairing_ui.h",
-    "webui/chromeos/certificate_manager_dialog_ui.cc",
-    "webui/chromeos/certificate_manager_dialog_ui.h",
+
+    # TODO(dbeam): why are all these /chromeos/ files on all platforms?

[wychen, 2017/06/09 23:07:55]

GN magically filter files based on their names, so that gn files can be simpler.

[Dan Beam, 2017/06/09 23:45:22]

if that's the case, why did I have to move all these files with /chromeos/ in
the path to an if (is_chromeos) { block to appease check_gn_headers?

https://codereview.chromium.org/2927273002/diff2/60001:80001/chrome/browser/u...

     "webui/chromeos/choose_mobile_network_ui.cc",
     "webui/chromeos/choose_mobile_network_ui.h",
     "webui/chromeos/cryptohome_ui.cc",
     "webui/chromeos/cryptohome_ui.h",
     "webui/chromeos/cryptohome_web_ui_handler.cc",
     "webui/chromeos/cryptohome_web_ui_handler.h",
     "webui/chromeos/drive_internals_ui.cc",
     "webui/chromeos/drive_internals_ui.h",
     "webui/chromeos/first_run/first_run_actor.cc",
     "webui/chromeos/first_run/first_run_actor.h",
@@ skipping 85 matching lines @@
     "webui/chromeos/mobile_setup_dialog.cc",
     "webui/chromeos/mobile_setup_dialog.h",
     "webui/chromeos/mobile_setup_ui.cc",
     "webui/chromeos/mobile_setup_ui.h",
     "webui/chromeos/network_element_localized_strings_provider.cc",
     "webui/chromeos/network_element_localized_strings_provider.h",
     "webui/chromeos/network_ui.cc",
     "webui/chromeos/network_ui.h",
     "webui/chromeos/power_ui.cc",
     "webui/chromeos/power_ui.h",
-    "webui/chromeos/proxy_settings_ui.cc",
-    "webui/chromeos/proxy_settings_ui.h",
     "webui/chromeos/set_time_ui.cc",
     "webui/chromeos/set_time_ui.h",
     "webui/chromeos/sim_unlock_ui.cc",
     "webui/chromeos/sim_unlock_ui.h",
     "webui/chromeos/slow_trace_ui.cc",
     "webui/chromeos/slow_trace_ui.h",
     "webui/chromeos/slow_ui.cc",
     "webui/chromeos/slow_ui.h",
     "webui/chromeos/ui_account_tweaks.cc",
     "webui/chromeos/ui_account_tweaks.h",
@@ skipping 632 matching lines @@
       "webui/ntp/app_resource_cache_factory.cc",
       "webui/ntp/app_resource_cache_factory.h",
       "webui/ntp/core_app_launcher_handler.cc",
       "webui/ntp/core_app_launcher_handler.h",
       "webui/ntp/new_tab_ui.cc",
       "webui/ntp/new_tab_ui.h",
       "webui/ntp/ntp_resource_cache.cc",
       "webui/ntp/ntp_resource_cache.h",
       "webui/ntp/ntp_resource_cache_factory.cc",
       "webui/ntp/ntp_resource_cache_factory.h",
-      "webui/options/autofill_options_handler.cc",
-      "webui/options/autofill_options_handler.h",
-      "webui/options/automatic_settings_reset_handler.cc",
-      "webui/options/automatic_settings_reset_handler.h",
-      "webui/options/browser_options_handler.cc",
-      "webui/options/browser_options_handler.h",
-      "webui/options/chromeos/accounts_options_handler.cc",
-      "webui/options/chromeos/accounts_options_handler.h",
-      "webui/options/chromeos/bluetooth_options_handler.cc",
-      "webui/options/chromeos/bluetooth_options_handler.h",
-      "webui/options/chromeos/change_picture_options_handler.cc",
-      "webui/options/chromeos/change_picture_options_handler.h",
-      "webui/options/chromeos/core_chromeos_options_handler.cc",
-      "webui/options/chromeos/core_chromeos_options_handler.h",
-      "webui/options/chromeos/cros_language_options_handler.cc",
-      "webui/options/chromeos/cros_language_options_handler.h",
-      "webui/options/chromeos/date_time_options_handler.cc",
-      "webui/options/chromeos/date_time_options_handler.h",
-      "webui/options/chromeos/display_options_handler.cc",
-      "webui/options/chromeos/display_options_handler.h",
-      "webui/options/chromeos/display_overscan_handler.cc",
-      "webui/options/chromeos/display_overscan_handler.h",
-      "webui/options/chromeos/internet_options_handler.cc",
-      "webui/options/chromeos/internet_options_handler.h",
-      "webui/options/chromeos/internet_options_handler_strings.cc",
-      "webui/options/chromeos/internet_options_handler_strings.h",
-      "webui/options/chromeos/keyboard_handler.cc",
-      "webui/options/chromeos/keyboard_handler.h",
-      "webui/options/chromeos/options_stylus_handler.cc",
-      "webui/options/chromeos/options_stylus_handler.h",
-      "webui/options/chromeos/pointer_handler.cc",
-      "webui/options/chromeos/pointer_handler.h",
-      "webui/options/chromeos/power_handler.cc",
-      "webui/options/chromeos/power_handler.h",
-      "webui/options/chromeos/proxy_handler.cc",
-      "webui/options/chromeos/proxy_handler.h",
-      "webui/options/chromeos/stats_options_handler.cc",
-      "webui/options/chromeos/stats_options_handler.h",
-      "webui/options/chromeos/storage_manager_handler.cc",
-      "webui/options/chromeos/storage_manager_handler.h",
-      "webui/options/chromeos/user_image_source.cc",
-      "webui/options/chromeos/user_image_source.h",
-      "webui/options/clear_browser_data_handler.cc",
-      "webui/options/clear_browser_data_handler.h",
-      "webui/options/content_settings_handler.cc",
-      "webui/options/content_settings_handler.h",
-      "webui/options/cookies_view_handler.cc",
-      "webui/options/cookies_view_handler.h",
-      "webui/options/core_options_handler.cc",
-      "webui/options/core_options_handler.h",
-      "webui/options/create_profile_handler.cc",
-      "webui/options/create_profile_handler.h",
-      "webui/options/easy_unlock_handler.cc",
-      "webui/options/easy_unlock_handler.h",
-      "webui/options/font_settings_handler.cc",
-      "webui/options/font_settings_handler.h",
-      "webui/options/font_settings_utils.cc",
-      "webui/options/font_settings_utils.h",
-      "webui/options/font_settings_utils_linux.cc",
-      "webui/options/font_settings_utils_mac.mm",
-      "webui/options/font_settings_utils_win.cc",
-      "webui/options/handler_options_handler.cc",
-      "webui/options/handler_options_handler.h",
-      "webui/options/help_overlay_handler.cc",
-      "webui/options/help_overlay_handler.h",
-      "webui/options/home_page_overlay_handler.cc",
-      "webui/options/home_page_overlay_handler.h",
-      "webui/options/import_data_handler.cc",
-      "webui/options/import_data_handler.h",
-      "webui/options/language_dictionary_overlay_handler.cc",
-      "webui/options/language_dictionary_overlay_handler.h",
-      "webui/options/language_options_handler.cc",
-      "webui/options/language_options_handler.h",
-      "webui/options/language_options_handler_common.cc",
-      "webui/options/language_options_handler_common.h",
-      "webui/options/manage_profile_handler.cc",
-      "webui/options/manage_profile_handler.h",
-      "webui/options/media_devices_selection_handler.cc",
-      "webui/options/media_devices_selection_handler.h",
-      "webui/options/options_ui.cc",
-      "webui/options/options_ui.h",
-      "webui/options/password_manager_handler.cc",
-      "webui/options/password_manager_handler.h",
-      "webui/options/reset_profile_settings_handler.cc",
-      "webui/options/reset_profile_settings_handler.h",
-      "webui/options/search_engine_manager_handler.cc",
-      "webui/options/search_engine_manager_handler.h",
-      "webui/options/startup_pages_handler.cc",
-      "webui/options/startup_pages_handler.h",
-      "webui/options/supervised_user_create_confirm_handler.cc",
-      "webui/options/supervised_user_create_confirm_handler.h",
-      "webui/options/supervised_user_import_handler.cc",
-      "webui/options/supervised_user_import_handler.h",
-      "webui/options/supervised_user_learn_more_handler.cc",
-      "webui/options/supervised_user_learn_more_handler.h",
-      "webui/options/sync_setup_handler.cc",
-      "webui/options/sync_setup_handler.h",
       "webui/plural_string_handler.cc",
       "webui/plural_string_handler.h",
       "webui/policy_indicator_localized_strings_provider.cc",
       "webui/policy_indicator_localized_strings_provider.h",
       "webui/profile_helper.cc",
       "webui/profile_helper.h",
       "webui/profile_info_watcher.cc",
       "webui/profile_info_watcher.h",
       "webui/set_as_default_browser_ui_win.cc",
       "webui/set_as_default_browser_ui_win.h",
@@ skipping 186 matching lines @@
       "views/apps/chrome_native_app_window_views_aura_ash.cc",
       "views/apps/chrome_native_app_window_views_aura_ash.h",
       "views/intent_picker_bubble_view.cc",
       "views/intent_picker_bubble_view.h",
 
       # On chromeos, file manager extension handles the file open/save dialog.
       "views/select_file_dialog_extension.cc",
       "views/select_file_dialog_extension.h",
       "views/select_file_dialog_extension_factory.cc",
       "views/select_file_dialog_extension_factory.h",
+      "webui/chromeos/bluetooth_pairing_ui.cc",
+      "webui/chromeos/bluetooth_pairing_ui.h",
+      "webui/chromeos/certificate_manager_dialog_ui.cc",
+      "webui/chromeos/certificate_manager_dialog_ui.h",
+      "webui/chromeos/proxy_settings_ui.cc",
+      "webui/chromeos/proxy_settings_ui.h",
+      "webui/options/autofill_options_handler.cc",
+      "webui/options/autofill_options_handler.h",
+      "webui/options/automatic_settings_reset_handler.cc",
+      "webui/options/automatic_settings_reset_handler.h",
+      "webui/options/browser_options_handler.cc",
+      "webui/options/browser_options_handler.h",
+      "webui/options/chromeos/accounts_options_handler.cc",
+      "webui/options/chromeos/accounts_options_handler.h",
+      "webui/options/chromeos/bluetooth_options_handler.cc",
+      "webui/options/chromeos/bluetooth_options_handler.h",
+      "webui/options/chromeos/change_picture_options_handler.cc",
+      "webui/options/chromeos/change_picture_options_handler.h",
+      "webui/options/chromeos/core_chromeos_options_handler.cc",
+      "webui/options/chromeos/core_chromeos_options_handler.h",
+      "webui/options/chromeos/cros_language_options_handler.cc",
+      "webui/options/chromeos/cros_language_options_handler.h",
+      "webui/options/chromeos/date_time_options_handler.cc",
+      "webui/options/chromeos/date_time_options_handler.h",
+      "webui/options/chromeos/display_options_handler.cc",
+      "webui/options/chromeos/display_options_handler.h",
+      "webui/options/chromeos/display_overscan_handler.cc",
+      "webui/options/chromeos/display_overscan_handler.h",
+      "webui/options/chromeos/internet_options_handler.cc",
+      "webui/options/chromeos/internet_options_handler.h",
+      "webui/options/chromeos/internet_options_handler_strings.cc",
+      "webui/options/chromeos/internet_options_handler_strings.h",
+      "webui/options/chromeos/keyboard_handler.cc",
+      "webui/options/chromeos/keyboard_handler.h",
+      "webui/options/chromeos/options_stylus_handler.cc",
+      "webui/options/chromeos/options_stylus_handler.h",
+      "webui/options/chromeos/pointer_handler.cc",
+      "webui/options/chromeos/pointer_handler.h",
+      "webui/options/chromeos/power_handler.cc",
+      "webui/options/chromeos/power_handler.h",
+      "webui/options/chromeos/proxy_handler.cc",
+      "webui/options/chromeos/proxy_handler.h",
+      "webui/options/chromeos/stats_options_handler.cc",
+      "webui/options/chromeos/stats_options_handler.h",
+      "webui/options/chromeos/storage_manager_handler.cc",
+      "webui/options/chromeos/storage_manager_handler.h",
+      "webui/options/chromeos/user_image_source.cc",
+      "webui/options/chromeos/user_image_source.h",
+      "webui/options/clear_browser_data_handler.cc",
+      "webui/options/clear_browser_data_handler.h",
+      "webui/options/content_settings_handler.cc",
+      "webui/options/content_settings_handler.h",
+      "webui/options/cookies_view_handler.cc",
+      "webui/options/cookies_view_handler.h",
+      "webui/options/core_options_handler.cc",
+      "webui/options/core_options_handler.h",
+      "webui/options/create_profile_handler.cc",
+      "webui/options/create_profile_handler.h",
+      "webui/options/easy_unlock_handler.cc",
+      "webui/options/easy_unlock_handler.h",
+      "webui/options/font_settings_handler.cc",
+      "webui/options/font_settings_handler.h",
+      "webui/options/handler_options_handler.cc",
+      "webui/options/handler_options_handler.h",
+      "webui/options/help_overlay_handler.cc",
+      "webui/options/help_overlay_handler.h",
+      "webui/options/home_page_overlay_handler.cc",
+      "webui/options/home_page_overlay_handler.h",
+      "webui/options/import_data_handler.cc",
+      "webui/options/import_data_handler.h",
+      "webui/options/language_dictionary_overlay_handler.cc",
+      "webui/options/language_dictionary_overlay_handler.h",
+      "webui/options/language_options_handler.cc",
+      "webui/options/language_options_handler.h",
+      "webui/options/language_options_handler_common.cc",
+      "webui/options/language_options_handler_common.h",
+      "webui/options/manage_profile_handler.cc",
+      "webui/options/manage_profile_handler.h",
+      "webui/options/media_devices_selection_handler.cc",
+      "webui/options/media_devices_selection_handler.h",
+      "webui/options/options_ui.cc",
+      "webui/options/options_ui.h",
+      "webui/options/password_manager_handler.cc",
+      "webui/options/password_manager_handler.h",
+      "webui/options/reset_profile_settings_handler.cc",
+      "webui/options/reset_profile_settings_handler.h",
+      "webui/options/search_engine_manager_handler.cc",
+      "webui/options/search_engine_manager_handler.h",
+      "webui/options/startup_pages_handler.cc",
+      "webui/options/startup_pages_handler.h",
+      "webui/options/supervised_user_create_confirm_handler.cc",
+      "webui/options/supervised_user_create_confirm_handler.h",
+      "webui/options/supervised_user_import_handler.cc",
+      "webui/options/supervised_user_import_handler.h",
+      "webui/options/supervised_user_learn_more_handler.cc",
+      "webui/options/supervised_user_learn_more_handler.h",
+      "webui/options/sync_setup_handler.cc",
+      "webui/options/sync_setup_handler.h",
     ]
     deps += [
       "//chrome/browser/chromeos",
       "//components/arc",
       "//components/drive:drive_chromeos",
       "//components/exo",
       "//components/login",
       "//device/power_save_blocker",
       "//ui/base/ime",
       "//ui/chromeos",
@@ skipping 873 matching lines @@
         "views/message_center/web_notification_tray.h",
       ]
     }
   }
   if (use_nss_certs) {
     sources += [
       "crypto_module_delegate_nss.cc",
       "crypto_module_delegate_nss.h",
       "crypto_module_password_dialog_nss.cc",
       "crypto_module_password_dialog_nss.h",
-      "webui/options/certificate_manager_handler.cc",
-      "webui/options/certificate_manager_handler.h",
       "webui/settings/certificates_handler.cc",
       "webui/settings/certificates_handler.h",
     ]
+    if (is_chromeos) {
+      sources += [
+        "webui/options/certificate_manager_handler.cc",
+        "webui/options/certificate_manager_handler.h",
+      ]
+    }
   }
   if (is_mac || is_win) {
     sources += [
       "webui/settings/native_certificates_handler.cc",
       "webui/settings/native_certificates_handler.h",
     ]
   }
   if (enable_print_preview) {
     sources += [
       "webui/print_preview/extension_printer_handler.cc",
@@ skipping 1419 matching lines @@
     deps += [
       "//chrome/test:test_support_ui",
       "//components/zoom",
     ]
   }
 
   if (enable_extensions) {
     deps += [ "//extensions/browser" ]
   }
 }