Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: device/generic_sensor/public/interfaces/sensor.mojom

Issue 2927263002: Add |notify_client_on_reading_change| flag to sensor configuration (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/generic_sensor/public/interfaces/sensor.mojom
diff --git a/device/generic_sensor/public/interfaces/sensor.mojom b/device/generic_sensor/public/interfaces/sensor.mojom
index 533272a84bab4fa33d767f0b2e897cd8fe7ffc35..ce38207b80d47b63ba899583f0528c97377613b5 100644
--- a/device/generic_sensor/public/interfaces/sensor.mojom
+++ b/device/generic_sensor/public/interfaces/sensor.mojom
@@ -40,6 +40,15 @@ struct SensorConfiguration {
// Requested frequency in Hz.
double frequency;
// TODO(shalamov): Add map<string, union> for sensor specific configuration.
+
+ // For sensors with ON_CHANGE reporting mode:
+ // If at least one configuration sets this flag to false,
+ // SensorClient::SensorReadingChanged() signal is sent to the client;
+ // otherwise it is not.
Reilly Grant (use Gerrit) 2017/06/09 22:10:02 This comment doesn't seem accurate.
juncai 2017/06/09 22:52:32 Done.
+ // For sensors with CONTINUOUS reporting mode:
+ // This flag has no effect since SensorClient::SensorReadingChanged() is not
+ // sent to the client.
+ bool suppress_on_change_events = false;
};
// Interface for controlling the Sensor.

Powered by Google App Engine
This is Rietveld 408576698