Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6129)

Unified Diff: chrome/browser/metrics/cloned_install_detector.h

Issue 292723004: Remove ClonedInstallDetector/MachineIdProvider //content dependencies (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Eliminate test dependency Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/cloned_install_detector.h
diff --git a/chrome/browser/metrics/cloned_install_detector.h b/chrome/browser/metrics/cloned_install_detector.h
index ced164db90a5b212c387ecaf366f0b5b250a8897..e1f22f59b899227ec0054e125c9e24bfaf416ddc 100644
--- a/chrome/browser/metrics/cloned_install_detector.h
+++ b/chrome/browser/metrics/cloned_install_detector.h
@@ -12,6 +12,10 @@
class PrefRegistrySimple;
class PrefService;
+namespace base {
+class SingleThreadTaskRunner;
+}
+
namespace metrics {
class MachineIdProvider;
@@ -23,12 +27,15 @@ class ClonedInstallDetector {
explicit ClonedInstallDetector(MachineIdProvider* raw_id_provider);
virtual ~ClonedInstallDetector();
- // Posts a task to generate a machine ID and store it to a local state pref.
- // If the newly generated ID is different than the previously stored one, then
- // the install is considered cloned. The ID is a 24-bit value based off of
- // machine characteristics. This value should never be sent over the network.
+ // Posts a task to |task_runner| to generate a machine ID and store it to a
+ // local state pref. If the newly generated ID is different than the
Ilya Sherman 2014/05/19 13:24:02 nit: This file seems to use one space following a
blundell 2014/05/19 13:31:23 Done.
+ // previously stored one, then the install is considered cloned. The ID is a
+ // 24-bit value based off of machine characteristics. This value should never
+ // be sent over the network.
// TODO(jwd): Implement change detection.
- void CheckForClonedInstall(PrefService* local_state);
+ void CheckForClonedInstall(
+ PrefService* local_state,
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner);
static void RegisterPrefs(PrefRegistrySimple* registry);

Powered by Google App Engine
This is Rietveld 408576698