Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 292723004: Remove ClonedInstallDetector/MachineIdProvider //content dependencies (Closed)

Created:
6 years, 7 months ago by blundell
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, Alexei Svitkine (slow)
Visibility:
Public.

Description

Remove ClonedInstallDetector/MachineIdProvider //content dependencies ClonedInstallDetector now takes in a base::SingleThreadTaskRunner rather than directly using content::BrowserThread::File. MachineIdProvider asserts that the task runner on which it's operating has IO allowed rather than checking that it's on the FILE thread. BUG=374213 TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271637

Patch Set 1 #

Patch Set 2 : Remove include #

Patch Set 3 : Eliminate test dependency #

Total comments: 4

Patch Set 4 : Response to review #

Patch Set 5 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -23 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/cloned_install_detector.h View 1 2 3 2 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/metrics/cloned_install_detector.cc View 1 2 3 4 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/metrics/machine_id_provider_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/machine_id_provider_win_unittest.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_state_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_state_manager.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
blundell
isherman: for review asvitkine: FYI
6 years, 7 months ago (2014-05-19 13:11:34 UTC) #1
Ilya Sherman
Nice! LGTM with nits: https://codereview.chromium.org/292723004/diff/40001/chrome/browser/metrics/cloned_install_detector.h File chrome/browser/metrics/cloned_install_detector.h (right): https://codereview.chromium.org/292723004/diff/40001/chrome/browser/metrics/cloned_install_detector.h#newcode31 chrome/browser/metrics/cloned_install_detector.h:31: // local state pref. If ...
6 years, 7 months ago (2014-05-19 13:24:02 UTC) #2
blundell
https://codereview.chromium.org/292723004/diff/40001/chrome/browser/metrics/cloned_install_detector.h File chrome/browser/metrics/cloned_install_detector.h (right): https://codereview.chromium.org/292723004/diff/40001/chrome/browser/metrics/cloned_install_detector.h#newcode31 chrome/browser/metrics/cloned_install_detector.h:31: // local state pref. If the newly generated ID ...
6 years, 7 months ago (2014-05-19 13:31:23 UTC) #3
blundell
TBR=jochen for chrome_browser_main
6 years, 7 months ago (2014-05-19 13:32:00 UTC) #4
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 7 months ago (2014-05-19 13:32:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/292723004/50001
6 years, 7 months ago (2014-05-19 13:32:44 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 17:41:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 18:06:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/17672)
6 years, 7 months ago (2014-05-19 18:06:01 UTC) #9
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 7 months ago (2014-05-20 09:39:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/292723004/70001
6 years, 7 months ago (2014-05-20 09:39:52 UTC) #11
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-20 10:58:08 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 14:49:16 UTC) #13
Message was sent while issue was closed.
Change committed as 271637

Powered by Google App Engine
This is Rietveld 408576698