Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

Issue 292723003: Fix browser test to work with dynamic CLD (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cld_browsertest
Patch Set: Add call to Init() to workaround gtest macro issues Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
index ca94fa4b4bdf3b46c9bb8070d1b2978e486c7291..6b91b9c838232cfe2818a4a2307d26a7175c7412 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
@@ -6,6 +6,7 @@
#include "base/command_line.h"
#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/translate/translate_browser_test_utils.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_tabstrip.h"
@@ -27,6 +28,8 @@ class TranslateBubbleViewBrowserTest : public InProcessBrowserTest {
IN_PROC_BROWSER_TEST_F(TranslateBubbleViewBrowserTest,
CloseBrowserWithoutTranslating) {
+ test::ScopedCLDDynamicDataHarness dynamic_data_scope;
msw 2014/05/19 18:56:42 As I asked in https://codereview.chromium.org/2852
+ ASSERT_NO_FATAL_FAILURE(dynamic_data_scope.Init());
EXPECT_FALSE(TranslateBubbleView::IsShowing());
// Show a French page and wait until the bubble is shown.
@@ -50,6 +53,8 @@ IN_PROC_BROWSER_TEST_F(TranslateBubbleViewBrowserTest,
IN_PROC_BROWSER_TEST_F(TranslateBubbleViewBrowserTest,
CloseLastTabWithoutTranslating) {
+ test::ScopedCLDDynamicDataHarness dynamic_data_scope;
+ ASSERT_NO_FATAL_FAILURE(dynamic_data_scope.Init());
EXPECT_FALSE(TranslateBubbleView::IsShowing());
// Show a French page and wait until the bubble is shown.
@@ -74,6 +79,8 @@ IN_PROC_BROWSER_TEST_F(TranslateBubbleViewBrowserTest,
IN_PROC_BROWSER_TEST_F(TranslateBubbleViewBrowserTest,
CloseAnotherTabWithoutTranslating) {
+ test::ScopedCLDDynamicDataHarness dynamic_data_scope;
+ ASSERT_NO_FATAL_FAILURE(dynamic_data_scope.Init());
EXPECT_FALSE(TranslateBubbleView::IsShowing());
int active_index = browser()->tab_strip_model()->active_index();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698