Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

Issue 292723003: Fix browser test to work with dynamic CLD (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cld_browsertest
Patch Set: Delay Init() even later for PathService initialization Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
index ca94fa4b4bdf3b46c9bb8070d1b2978e486c7291..d4741648aafdd23b4d9e3ef40a7728adea786101 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
@@ -6,6 +6,7 @@
#include "base/command_line.h"
#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/translate/translate_browser_test_utils.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_tabstrip.h"
@@ -20,8 +21,15 @@ class TranslateBubbleViewBrowserTest : public InProcessBrowserTest {
public:
TranslateBubbleViewBrowserTest() {}
virtual ~TranslateBubbleViewBrowserTest() {}
+ virtual void SetUpOnMainThread() OVERRIDE {
+ // We can't Init() until PathService has been initialized. This happens
+ // very late in the test fixture setup process.
+ dynamic_data_scope.Init();
+ InProcessBrowserTest::SetUpOnMainThread();
+ }
private:
+ test::ScopedCLDDynamicDataHarness dynamic_data_scope;
DISALLOW_COPY_AND_ASSIGN(TranslateBubbleViewBrowserTest);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698