Issue 292713002: Revert "Simplify debugger state."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292713002: Revert "Simplify debugger state." (Closed)

Created:
6 years, 7 months ago by Sven Panne

Modified:
6 years, 7 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Simplify debugger state." This reverts r21346, it broke the layout tests. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21351

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+208 lines, -113 lines)			Patch
M	src/bootstrapper.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/d8.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/debug.h	View	7 chunks	+56 lines, -35 lines	0 comments	Download
M	src/debug.cc	View	13 chunks	+118 lines, -52 lines	0 comments	Download
M	src/execution.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	5 chunks	+17 lines, -13 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-stepin-positions.js	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

6 years, 7 months ago (2014-05-19 07:06:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21351 (tree was closed).