Chromium Code Reviews| Index: chrome/browser/safe_browsing/client_side_detection_host.cc |
| diff --git a/chrome/browser/safe_browsing/client_side_detection_host.cc b/chrome/browser/safe_browsing/client_side_detection_host.cc |
| index 838bc9dd920e488eda7236efc83c785606b34673..199809b7f846d56d4f38b9c53451afafb8f09daf 100644 |
| --- a/chrome/browser/safe_browsing/client_side_detection_host.cc |
| +++ b/chrome/browser/safe_browsing/client_side_detection_host.cc |
| @@ -110,12 +110,12 @@ class ClientSideDetectionHost::ShouldClassifyUrlRequest |
| DontClassifyForMalware(NO_CLASSIFY_PRIVATE_IP); |
| } |
| - // For phishing we only classify HTTP pages. |
| - if (!url_.SchemeIs(url::kHttpScheme)) { |
| + // For phishing we only classify HTTP or HTTPS pages. |
| + if (!url_.SchemeIsHTTPOrHTTPS()) { |
| DVLOG(1) << "Skipping phishing classification for URL: " << url_ |
| - << " because it is not HTTP: " |
| + << " because it is not HTTP or HTTPS: " |
| << socket_address_.host(); |
| - DontClassifyForPhishing(NO_CLASSIFY_NOT_HTTP_URL); |
| + DontClassifyForPhishing(NO_CLASSIFY_SCHEME_NOT_SUPPORTED); |
| } |
| // Don't run any classifier if the tab is incognito. |
| @@ -166,7 +166,8 @@ class ClientSideDetectionHost::ShouldClassifyUrlRequest |
| NO_CLASSIFY_KILLSWITCH, |
| NO_CLASSIFY_CANCEL, |
| NO_CLASSIFY_RESULT_FROM_CACHE, |
| - NO_CLASSIFY_NOT_HTTP_URL, |
| + DEPRECATED_NO_CLASSIFY_NOT_HTTP_URL, |
| + NO_CLASSIFY_SCHEME_NOT_SUPPORTED, |
|
Nathan Parker
2017/06/12 21:43:56
nit: add integer values to these to verify they ma
Jialiu Lin
2017/06/12 21:59:34
Done.
|
| NO_CLASSIFY_MAX // Always add new values before this one. |
| }; |