Enable client side phishing detection on https sites.

chrome/browser/safe_browsing/client_side_detection_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/client_side_detection_host.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 92 matching lines @@
     }
 
     if (csd_service_->IsPrivateIPAddress(socket_address_.host())) {
       DVLOG(1) << "Skipping phishing classification for URL: " << url_
                << " because of hosting on private IP: "
                << socket_address_.host();
       DontClassifyForPhishing(NO_CLASSIFY_PRIVATE_IP);
       DontClassifyForMalware(NO_CLASSIFY_PRIVATE_IP);
     }
 
-    // For phishing we only classify HTTP pages.
-    if (!url_.SchemeIs(url::kHttpScheme)) {
+    // For phishing we only classify HTTP or HTTPS pages.
+    if (!url_.SchemeIsHTTPOrHTTPS()) {
       DVLOG(1) << "Skipping phishing classification for URL: " << url_
-               << " because it is not HTTP: "
+               << " because it is not HTTP or HTTPS: "
                << socket_address_.host();
-      DontClassifyForPhishing(NO_CLASSIFY_NOT_HTTP_URL);
+      DontClassifyForPhishing(NO_CLASSIFY_SCHEME_NOT_SUPPORTED);
     }
 
     // Don't run any classifier if the tab is incognito.
     if (web_contents_->GetBrowserContext()->IsOffTheRecord()) {
       DVLOG(1) << "Skipping phishing and malware classification for URL: "
                << url_ << " because we're browsing incognito.";
       DontClassifyForPhishing(NO_CLASSIFY_OFF_THE_RECORD);
       DontClassifyForMalware(NO_CLASSIFY_OFF_THE_RECORD);
     }
 
@@ skipping 20 matching lines @@
     csd_service_ = NULL;
     host_ = NULL;
   }
 
  private:
   friend class base::RefCountedThreadSafe<
       ClientSideDetectionHost::ShouldClassifyUrlRequest>;
 
   // Enum used to keep stats about why the pre-classification check failed.
   enum PreClassificationCheckFailures {
-    OBSOLETE_NO_CLASSIFY_PROXY_FETCH,
-    NO_CLASSIFY_PRIVATE_IP,
-    NO_CLASSIFY_OFF_THE_RECORD,
-    NO_CLASSIFY_MATCH_CSD_WHITELIST,
-    NO_CLASSIFY_TOO_MANY_REPORTS,
-    NO_CLASSIFY_UNSUPPORTED_MIME_TYPE,
-    NO_CLASSIFY_NO_DATABASE_MANAGER,
-    NO_CLASSIFY_KILLSWITCH,
-    NO_CLASSIFY_CANCEL,
-    NO_CLASSIFY_RESULT_FROM_CACHE,
-    NO_CLASSIFY_NOT_HTTP_URL,
+    OBSOLETE_NO_CLASSIFY_PROXY_FETCH = 0,
+    NO_CLASSIFY_PRIVATE_IP = 1,
+    NO_CLASSIFY_OFF_THE_RECORD = 2,
+    NO_CLASSIFY_MATCH_CSD_WHITELIST = 3,
+    NO_CLASSIFY_TOO_MANY_REPORTS = 4,
+    NO_CLASSIFY_UNSUPPORTED_MIME_TYPE = 5,
+    NO_CLASSIFY_NO_DATABASE_MANAGER = 6,
+    NO_CLASSIFY_KILLSWITCH = 7,
+    NO_CLASSIFY_CANCEL = 8,
+    NO_CLASSIFY_RESULT_FROM_CACHE = 9,
+    DEPRECATED_NO_CLASSIFY_NOT_HTTP_URL = 10,
+    NO_CLASSIFY_SCHEME_NOT_SUPPORTED = 11,
 
     NO_CLASSIFY_MAX  // Always add new values before this one.
   };
 
   // The destructor can be called either from the UI or the IO thread.
   virtual ~ShouldClassifyUrlRequest() { }
 
   bool ShouldClassifyForPhishing() const {
     DCHECK_CURRENTLY_ON(BrowserThread::UI);
     return !start_phishing_classification_cb_.is_null();
@@ skipping 541 matching lines @@
     ui_manager_->RemoveObserver(this);
 
   ui_manager_ = ui_manager;
   if (ui_manager)
     ui_manager_->AddObserver(this);
 
   database_manager_ = database_manager;
 }
 
 }  // namespace safe_browsing