Enable client side phishing detection on https sites.

chrome/browser/safe_browsing/client_side_detection_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/client_side_detection_host.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 92 matching lines @@
     }
 
     if (csd_service_->IsPrivateIPAddress(socket_address_.host())) {
       DVLOG(1) << "Skipping phishing classification for URL: " << url_
                << " because of hosting on private IP: "
                << socket_address_.host();
       DontClassifyForPhishing(NO_CLASSIFY_PRIVATE_IP);
       DontClassifyForMalware(NO_CLASSIFY_PRIVATE_IP);
     }
 
-    // For phishing we only classify HTTP pages.

[vakh (use Gerrit instead), 2017/06/08 23:30:31]

Any chance this was intended as: this URL is not HTTP (or HTTPS)
but the code only checked for HTTP.

We do this for DB checks also:
https://cs.chromium.org/chromium/src/components/safe_browsing_db/v4_local_dat...

[Jialiu Lin, 2017/06/09 00:26:11]

Good catch. You're right. I should be aware of other schemes.

-    if (!url_.SchemeIs(url::kHttpScheme)) {
-      DVLOG(1) << "Skipping phishing classification for URL: " << url_
-               << " because it is not HTTP: "
-               << socket_address_.host();
-      DontClassifyForPhishing(NO_CLASSIFY_NOT_HTTP_URL);
-    }
-
     // Don't run any classifier if the tab is incognito.
     if (web_contents_->GetBrowserContext()->IsOffTheRecord()) {
       DVLOG(1) << "Skipping phishing and malware classification for URL: "
                << url_ << " because we're browsing incognito.";
       DontClassifyForPhishing(NO_CLASSIFY_OFF_THE_RECORD);
       DontClassifyForMalware(NO_CLASSIFY_OFF_THE_RECORD);
     }
 
     // We lookup the csd-whitelist before we lookup the cache because
     // a URL may have recently been whitelisted.  If the URL matches
@@ skipping 28 matching lines @@
     OBSOLETE_NO_CLASSIFY_PROXY_FETCH,
     NO_CLASSIFY_PRIVATE_IP,
     NO_CLASSIFY_OFF_THE_RECORD,
     NO_CLASSIFY_MATCH_CSD_WHITELIST,
     NO_CLASSIFY_TOO_MANY_REPORTS,
     NO_CLASSIFY_UNSUPPORTED_MIME_TYPE,
     NO_CLASSIFY_NO_DATABASE_MANAGER,
     NO_CLASSIFY_KILLSWITCH,
     NO_CLASSIFY_CANCEL,
     NO_CLASSIFY_RESULT_FROM_CACHE,
-    NO_CLASSIFY_NOT_HTTP_URL,
+    DEPRECATED_NO_CLASSIFY_NOT_HTTP_URL,
 
     NO_CLASSIFY_MAX  // Always add new values before this one.
   };
 
   // The destructor can be called either from the UI or the IO thread.
   virtual ~ShouldClassifyUrlRequest() { }
 
   bool ShouldClassifyForPhishing() const {
     DCHECK_CURRENTLY_ON(BrowserThread::UI);
     return !start_phishing_classification_cb_.is_null();
@@ skipping 541 matching lines @@
     ui_manager_->RemoveObserver(this);
 
   ui_manager_ = ui_manager;
   if (ui_manager)
     ui_manager_->AddObserver(this);
 
   database_manager_ = database_manager;
 }
 
 }  // namespace safe_browsing