Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2927093002: Support user class in compile_from_dill_test (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, Emily Fortuna
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -188 lines) Patch
M pkg/compiler/lib/src/closure.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +104 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 5 chunks +18 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 31 chunks +77 lines, -153 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-08 14:35:46 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2927093002/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): https://codereview.chromium.org/2927093002/diff/1/pkg/compiler/lib/src/world.dart#newcode547 pkg/compiler/lib/src/world.dart:547: "No ClassSet for $y (${y.runtimeType}): ${dump(y)} : ${_classSets}")); ...
3 years, 6 months ago (2017-06-08 18:10:22 UTC) #3
Johnni Winther
https://codereview.chromium.org/2927093002/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): https://codereview.chromium.org/2927093002/diff/1/pkg/compiler/lib/src/world.dart#newcode547 pkg/compiler/lib/src/world.dart:547: "No ClassSet for $y (${y.runtimeType}): ${dump(y)} : ${_classSets}")); On ...
3 years, 6 months ago (2017-06-09 10:27:10 UTC) #4
Johnni Winther
3 years, 6 months ago (2017-06-09 10:36:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
89e2719f2f2d73c1353868ab5127f49a1ea35b3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698