Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

Issue 2927063003: Revert of [DevTools] Show icon in top toolbar when Node target is available (patchset #3 id:40001 o… (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {SDK.SDKModelObserver<!SDK.DebuggerModel>} 5 * @implements {SDK.SDKModelObserver<!SDK.DebuggerModel>}
6 * @implements {UI.ListDelegate<!SDK.DebuggerModel>} 6 * @implements {UI.ListDelegate<!SDK.DebuggerModel>}
7 */ 7 */
8 Sources.ThreadsSidebarPane = class extends UI.VBox { 8 Sources.ThreadsSidebarPane = class extends UI.VBox {
9 constructor() { 9 constructor() {
10 super(true); 10 super(true);
11 this.registerRequiredCSS('sources/threadsSidebarPane.css'); 11 this.registerRequiredCSS('sources/threadsSidebarPane.css');
12 12
13 /** @type {!UI.ListModel<!SDK.DebuggerModel>} */ 13 /** @type {!UI.ListModel<!SDK.DebuggerModel>} */
14 this._items = new UI.ListModel(); 14 this._items = new UI.ListModel();
15 /** @type {!UI.ListControl<!SDK.DebuggerModel>} */ 15 /** @type {!UI.ListControl<!SDK.DebuggerModel>} */
16 this._list = new UI.ListControl(this._items, this, UI.ListMode.NonViewport); 16 this._list = new UI.ListControl(this._items, this, UI.ListMode.NonViewport);
17 this.contentElement.appendChild(this._list.element); 17 this.contentElement.appendChild(this._list.element);
18 18
19 this._availableNodeTargetsElement = this.contentElement.createChild('div', ' hidden available-node-targets');
20
19 UI.context.addFlavorChangeListener(SDK.Target, this._targetFlavorChanged, th is); 21 UI.context.addFlavorChangeListener(SDK.Target, this._targetFlavorChanged, th is);
22
23 SDK.targetManager.addEventListener(
24 SDK.TargetManager.Events.AvailableNodeTargetsChanged, this._availableNod eTargetsChanged, this);
25 this._availableNodeTargetsChanged();
26
20 SDK.targetManager.observeModels(SDK.DebuggerModel, this); 27 SDK.targetManager.observeModels(SDK.DebuggerModel, this);
21 } 28 }
22 29
23 /** 30 /**
24 * @return {boolean} 31 * @return {boolean}
25 */ 32 */
26 static shouldBeShown() { 33 static shouldBeShown() {
27 var minJSTargets = Runtime.queryParam('nodeFrontend') ? 1 : 2; 34 var minJSTargets = Runtime.queryParam('nodeFrontend') ? 1 : 2;
28 return SDK.targetManager.models(SDK.DebuggerModel).length >= minJSTargets; 35 if (SDK.targetManager.models(SDK.DebuggerModel).length >= minJSTargets)
36 return true;
37 return !!SDK.targetManager.availableNodeTargetsCount();
38 }
39
40 _availableNodeTargetsChanged() {
41 var count = SDK.targetManager.availableNodeTargetsCount();
42 if (!count) {
43 this._availableNodeTargetsElement.classList.add('hidden');
44 return;
45 }
46 this._availableNodeTargetsElement.removeChildren();
47 this._availableNodeTargetsElement.createTextChild(
48 count === 1 ? Common.UIString('Node instance available.') :
49 Common.UIString('%d Node instances available.', count));
50 var link = this._availableNodeTargetsElement.createChild('span', 'link');
51 link.textContent = Common.UIString('Connect');
52 link.addEventListener('click', () => {
53 InspectorFrontendHost.openNodeFrontend();
54 }, false);
55 this._availableNodeTargetsElement.classList.remove('hidden');
29 } 56 }
30 57
31 /** 58 /**
32 * @override 59 * @override
33 * @param {!SDK.DebuggerModel} debuggerModel 60 * @param {!SDK.DebuggerModel} debuggerModel
34 * @return {!Element} 61 * @return {!Element}
35 */ 62 */
36 createElementForItem(debuggerModel) { 63 createElementForItem(debuggerModel) {
37 var element = createElementWithClass('div', 'thread-item'); 64 var element = createElementWithClass('div', 'thread-item');
38 var title = element.createChild('div', 'thread-item-title'); 65 var title = element.createChild('div', 'thread-item-title');
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 /** 152 /**
126 * @param {!Common.Event} event 153 * @param {!Common.Event} event
127 */ 154 */
128 _targetFlavorChanged(event) { 155 _targetFlavorChanged(event) {
129 var target = /** @type {!SDK.Target} */ (event.data); 156 var target = /** @type {!SDK.Target} */ (event.data);
130 var debuggerModel = target.model(SDK.DebuggerModel); 157 var debuggerModel = target.model(SDK.DebuggerModel);
131 if (debuggerModel) 158 if (debuggerModel)
132 this._list.selectItem(debuggerModel); 159 this._list.selectItem(debuggerModel);
133 } 160 }
134 }; 161 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698