Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2927043002: Handle `new Object()` in compile_from_dill_test (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -33 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 7 chunks +25 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-08 13:14:39 UTC) #2
Siggi Cherem (dart-lang)
lgtm! Woo hoo!
3 years, 6 months ago (2017-06-08 18:03:47 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-09 10:04:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29535a6ad970de38a36bb0edf4c57daa3b0b1589 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698