Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 292703004: Reenable two LoginUtilTests and add suppression. (Closed)

Created:
6 years, 7 months ago by benwells
Modified:
6 years, 7 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Reenable two LoginUtilTests and add suppression. These were incorrectly disabled after the stack trace for the suppressions changed. NOTRY=true TBR=jyasskin@chromium.org BUG=361044 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M tools/lsan/suppressions.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
6 years, 7 months ago (2014-05-19 07:33:29 UTC) #1
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 7 months ago (2014-05-19 07:33:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/292703004/1
6 years, 7 months ago (2014-05-19 07:33:45 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 07:34:22 UTC) #4
Message was sent while issue was closed.
Change committed as 271350

Powered by Google App Engine
This is Rietveld 408576698