Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292703002: Fix Windows GN build. (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Fix Windows GN build. The compiler file unconditionally depenended on the GCC version. TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 7 months ago (2014-05-19 04:57:57 UTC) #1
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 7 months ago (2014-05-19 04:58:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/292703002/1
6 years, 7 months ago (2014-05-19 04:58:15 UTC) #3
scottmg
lgtm
6 years, 7 months ago (2014-05-19 06:11:29 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 06:50:20 UTC) #5
Message was sent while issue was closed. 
Change committed as 271347

Powered by Google App Engine
This is Rietveld 408576698