Fix WebVR so we don't animation when stopped at a JS breakpoint

third_party/WebKit/Source/modules/vr/VRDisplay.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VRDisplay_h
 #define VRDisplay_h
 
 #include "core/dom/Document.h"
 #include "core/dom/FrameRequestCallback.h"
 #include "core/events/EventTarget.h"
 #include "device/vr/vr_service.mojom-blink.h"
 #include "modules/vr/VRDisplayCapabilities.h"
 #include "modules/vr/VRLayer.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "platform/Timer.h"
 #include "platform/heap/Handle.h"
 #include "platform/wtf/Forward.h"
 #include "platform/wtf/text/WTFString.h"
 #include "public/platform/WebGraphicsContext3DProvider.h"
 
+#include "core/dom/SuspendableObject.h"
+
 namespace gpu {
 namespace gles2 {
 class GLES2Interface;
 }
 }
 
 namespace blink {
 
 class NavigatorVR;
 class ScriptedAnimationController;
 class VRController;
 class VREyeParameters;
 class VRFrameData;
 class VRStageParameters;
 
 class WebGLRenderingContextBase;
 
 enum VREye { kVREyeNone, kVREyeLeft, kVREyeRight };
 
 class VRDisplay final : public EventTargetWithInlineData,
                         public ActiveScriptWrappable<VRDisplay>,
-                        public ContextLifecycleObserver,
+                        public SuspendableObject,
                         public device::mojom::blink::VRDisplayClient,
                         public device::mojom::blink::VRSubmitFrameClient {
   DEFINE_WRAPPERTYPEINFO();
   USING_GARBAGE_COLLECTED_MIXIN(VRDisplay);
   USING_PRE_FINALIZER(VRDisplay, Dispose);
 
  public:
   ~VRDisplay();
 
   unsigned displayId() const { return display_id_; }
@@ skipping 29 matching lines @@
   // EventTarget overrides:
   ExecutionContext* GetExecutionContext() const override;
   const AtomicString& InterfaceName() const override;
 
   // ContextLifecycleObserver implementation.
   void ContextDestroyed(ExecutionContext*) override;
 
   // ScriptWrappable implementation.
   bool HasPendingActivity() const final;
 
+  // SuspendableObject:
+  void Suspend() override;
+  void Resume() override;
+
   void FocusChanged();
 
   DECLARE_VIRTUAL_TRACE();
 
  protected:
   friend class VRController;
 
   VRDisplay(NavigatorVR*,
             device::mojom::blink::VRDisplayPtr,
             device::mojom::blink::VRDisplayClientRequest);
@@ skipping 100 matching lines @@
   bool pending_present_request_ = false;
 
   device::mojom::blink::VRDisplayPtr display_;
 
   mojo::Binding<device::mojom::blink::VRSubmitFrameClient>
       submit_frame_client_binding_;
   mojo::Binding<device::mojom::blink::VRDisplayClient> display_client_binding_;
   device::mojom::blink::VRVSyncProviderPtr vr_v_sync_provider_;
 
   HeapDeque<Member<ScriptPromiseResolver>> pending_present_resolvers_;
+
+  bool suspended_ = false;

[haraken, 2017/06/08 00:55:12]

You can drop this flag and instead use executionContext->IsSuspended().

[billorr, 2017/06/08 04:20:21]

Done.

+  bool request_vsync_on_resume_ = false;
 };
 
 using VRDisplayVector = HeapVector<Member<VRDisplay>>;
 
 enum class PresentationResult {
   kRequested = 0,
   kSuccess = 1,
   kSuccessAlreadyPresenting = 2,
   kVRDisplayCannotPresent = 3,
   kPresentationNotSupportedByDisplay = 4,
   kVRDisplayNotFound = 5,
   kNotInitiatedByUserGesture = 6,
   kInvalidNumberOfLayers = 7,
   kInvalidLayerSource = 8,
   kLayerSourceMissingWebGLContext = 9,
   kInvalidLayerBounds = 10,
   kServiceInactive = 11,
   kRequestDenied = 12,
   kFullscreenNotEnabled = 13,
   kPresentationResultMax,  // Must be last member of enum.
 };
 
 void ReportPresentationResult(PresentationResult);
 
 }  // namespace blink
 
 #endif  // VRDisplay_h