Skip directly to the last library to set the entry point and check importUri

Skip directly to the last library to set the entry point and check importUri
instead of fileUri.

On some scenarios fileUri is relative and entryUri was absolute, but importUri
should match for the entry library.

BUG=
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/cb5f3842c4518cd7427256bb2cefc4e36b73e729

[Siggi Cherem (dart-lang), 2017-06-07 21:23:46]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-06-07 21:24:17]

sigmund@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-06-07 21:31:16]

Thank you for fixing the URI problem.

https://codereview.chromium.org/2926933002/diff/20001/pkg/front_end/lib/src/i...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2926933002/diff/20001/pkg/front_end/lib/src/i...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:140: var
entryLibrary = program.libraries.last;
I thought about doing this, but decided that this is not perfectly safe. What if
the last strongly connected component (with the entry point) consists of two
libraries, and it happens that the entry point library is not the last one in
this component? Topological sorting does not guarantee this to us.

[Siggi Cherem (dart-lang), 2017-06-07 21:36:11]

thanks!

https://codereview.chromium.org/2926933002/diff/20001/pkg/front_end/lib/src/i...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2926933002/diff/20001/pkg/front_end/lib/src/i...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:140: var
entryLibrary = program.libraries.last;
On 2017/06/07 21:31:16, scheglov wrote:
> I thought about doing this, but decided that this is not perfectly safe. What
if
> the last strongly connected component (with the entry point) consists of two
> libraries, and it happens that the entry point library is not the last one in
> this component? Topological sorting does not guarantee this to us.

Good point, what do you think of either of these two ideas:
 - go backwards with program.libraries.reversed (it's likely closer to the end)
 - only visit libraries in results.last.kernelLibraries?

[scheglov, 2017-06-07 21:38:43]

https://codereview.chromium.org/2926933002/diff/20001/pkg/front_end/lib/src/i...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2926933002/diff/20001/pkg/front_end/lib/src/i...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:140: var
entryLibrary = program.libraries.last;
On 2017/06/07 21:36:10, Siggi Cherem (dart-lang) wrote:
> On 2017/06/07 21:31:16, scheglov wrote:
> > I thought about doing this, but decided that this is not perfectly safe.
What
> if
> > the last strongly connected component (with the entry point) consists of two
> > libraries, and it happens that the entry point library is not the last one
in
> > this component? Topological sorting does not guarantee this to us.
> 
> Good point, what do you think of either of these two ideas:
>  - go backwards with program.libraries.reversed (it's likely closer to the
end)
>  - only visit libraries in results.last.kernelLibraries?

Yeah, we know for sure that it is in the last result.

[Siggi Cherem (dart-lang), 2017-06-07 21:45:04]

PTAL - updated to look at the last cycle only

[scheglov, 2017-06-07 21:47:10]

LGTM

[Siggi Cherem (dart-lang), 2017-06-07 21:50:08]

Description was changed from

==========
Skip directly to the last library to set the entry point and check importUri
instead of fileUri.

On some scenarios fileUri is relative and entryUri was absolute, but importUri
should match for the entry library.

BUG=
==========

to

==========
Skip directly to the last library to set the entry point and check importUri
instead of fileUri.

On some scenarios fileUri is relative and entryUri was absolute, but importUri
should match for the entry library.

BUG=
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cb5f3842c4518cd7427256bb2cefc4e36b73e729
==========

[Siggi Cherem (dart-lang), 2017-06-07 21:50:10]

Committed patchset #2 (id:40001) manually as
cb5f3842c4518cd7427256bb2cefc4e36b73e729 (presubmit successful).