[DeviceLight] Browser+java part

content/renderer/device_sensors/device_light_event_pump.cc

Index: content/renderer/device_sensors/device_light_event_pump.cc
diff --git a/content/renderer/device_sensors/device_light_event_pump.cc b/content/renderer/device_sensors/device_light_event_pump.cc
index a20919d968d9f3637afe8fb3e1435255d98890ce..ccb91221b7026f5e0ebc5a92993170b1f81276f7 100644
--- a/content/renderer/device_sensors/device_light_event_pump.cc
+++ b/content/renderer/device_sensors/device_light_event_pump.cc
@@ -37,13 +37,22 @@ bool DeviceLightEventPump::OnControlMessageReceived(
 void DeviceLightEventPump::FireEvent() {
   DCHECK(listener());
   DeviceLightData data;
-  bool did_return_light_data = reader_->GetLatestData(&data);
-  if (did_return_light_data && data.value != last_seen_data_) {
+  if (reader_->GetLatestData(&data) && ShouldFireEvent(data.value)) {
     last_seen_data_ = data.value;
     listener()->didChangeDeviceLight(data.value);
   }
 }
 
+bool DeviceLightEventPump::ShouldFireEvent(double lux) const {
+  if (lux < 0)
+    return false;
+
+  if (lux != last_seen_data_ || lux == std::numeric_limits<double>::infinity())

[timvolodine, 2014/09/08 15:20:19]

could you add a comment regarding why infinity is special?
maybe something like this looks cleaner:
// ..
if (lux == infinity)
  return true;

return lux != last_seen_data;

[timvolodine, 2014/09/08 15:20:19]

also a unit test for this case would be desirable

[riju_, 2014/09/09 14:01:18]

Done.

[riju_, 2014/09/09 14:01:18]

Done.

+    return true;
+
+  return false;
+}
+
 bool DeviceLightEventPump::InitializeReader(base::SharedMemoryHandle handle) {
   if (!reader_)
     reader_.reset(new DeviceLightSharedMemoryReader());