Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: content/browser/device_sensors/data_fetcher_shared_memory_default.cc

Issue 292693004: [DeviceLight] Browser+java part (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot some light bits removal from device_inertial_sensor_diagnostics.html Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/device_sensors/data_fetcher_shared_memory_default.cc
diff --git a/content/browser/device_sensors/data_fetcher_shared_memory_default.cc b/content/browser/device_sensors/data_fetcher_shared_memory_default.cc
index 457fd8d5b474eeebdeb985cd91ac114b5dfdc258..d3e05453196f3eca3b3506fe815a95bb097f81d9 100644
--- a/content/browser/device_sensors/data_fetcher_shared_memory_default.cc
+++ b/content/browser/device_sensors/data_fetcher_shared_memory_default.cc
@@ -29,12 +29,22 @@ static bool SetOrientationBuffer(
return true;
}
+static bool SetLightBuffer(content::DeviceLightHardwareBuffer* buffer,
+ double lux) {
+ if (!buffer)
+ return false;
+ buffer->seqlock.WriteBegin();
+ buffer->data.value = lux;
+ buffer->seqlock.WriteEnd();
+ return true;
+}
+
} // namespace
namespace content {
DataFetcherSharedMemory::DataFetcherSharedMemory()
- : motion_buffer_(NULL), orientation_buffer_(NULL) {
+ : motion_buffer_(NULL), orientation_buffer_(NULL), light_buffer_(NULL) {
}
DataFetcherSharedMemory::~DataFetcherSharedMemory() {
@@ -54,6 +64,10 @@ bool DataFetcherSharedMemory::Start(ConsumerType consumer_type, void* buffer) {
UMA_HISTOGRAM_BOOLEAN("InertialSensor.OrientationDefaultAvailable",
false);
return SetOrientationBuffer(orientation_buffer_, true);
+ case CONSUMER_TYPE_LIGHT:
+ light_buffer_ = static_cast<DeviceLightHardwareBuffer*>(buffer);
+ return SetLightBuffer(light_buffer_,
+ std::numeric_limits<double>::infinity());
default:
NOTREACHED();
}
@@ -66,6 +80,8 @@ bool DataFetcherSharedMemory::Stop(ConsumerType consumer_type) {
return SetMotionBuffer(motion_buffer_, false);
case CONSUMER_TYPE_ORIENTATION:
return SetOrientationBuffer(orientation_buffer_, false);
+ case CONSUMER_TYPE_LIGHT:
+ return light_buffer_->data.value >= 0;
timvolodine 2014/09/08 15:20:18 for consistency I think return SetLightBuffer(..,
riju_ 2014/09/09 14:01:17 Done.
default:
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698