content/browser/device_sensors/inertial_sensor_consts.h - Issue 292693004: [DeviceLight] Browser+java part

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/device_sensors/inertial_sensor_consts.h

Issue 292693004: [DeviceLight] Browser+java part (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot some light bits removal from device_inertial_sensor_diagnostics.html Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/device_sensors/device_inertial_sensor_browsertest.cc ('K') | « content/browser/device_sensors/device_light_message_filter.cc ('k') | content/browser/device_sensors/sensor_manager_android.h » ('j') | content/browser/device_sensors/sensor_manager_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_DEVICE_SENSORS_INERTIAL_SENSOR_CONSTS_H_	5 #ifndef CONTENT_BROWSER_DEVICE_SENSORS_INERTIAL_SENSOR_CONSTS_H_

6 #define CONTENT_BROWSER_DEVICE_SENSORS_INERTIAL_SENSOR_CONSTS_H_	6 #define CONTENT_BROWSER_DEVICE_SENSORS_INERTIAL_SENSOR_CONSTS_H_

7	7

8 namespace content {	8 namespace content {

9	9

10 // Constants related to the Device Motion/Device Orientation APIs.	10 // Constants related to the Device {Motion\|Orientation\|Light} APIs.

11	11

12 enum ConsumerType {	12 enum ConsumerType {

13 CONSUMER_TYPE_MOTION = 1 << 0,	13 CONSUMER_TYPE_MOTION = 1 << 0,

14 CONSUMER_TYPE_ORIENTATION = 1 << 1,	14 CONSUMER_TYPE_ORIENTATION = 1 << 1,

	15 CONSUMER_TYPE_LIGHT = 1 << 2,

15 };	16 };

16	17

17 // Specifies the minimal interval between subsequent sensor data updates.	18 // Specifies the minimal interval between subsequent sensor data updates.

18 // Note that when changing this value it is desirable to have an adequate	19 // Note that when changing this value it is desirable to have an adequate

19 // matching value \|DeviceSensorEventPump::kDefaultPumpDelayMillis\| in	20 // matching value \|DeviceSensorEventPump::kDefaultPumpDelayMillis\| in

20 // content/renderer/device_orientation/device_sensor_event_pump.cc.	21 // content/renderer/device_sensors/device_sensor_event_pump.cc and

	22 // \|kDefaultLightPumpDelayMillis\| in
	timvolodine 2014/09/08 15:20:19 could you add this comment directly above LightSen could you add this comment directly above LightSensorIntervalMillis? riju_ 2014/09/09 14:01:18 Done. Show quoted text On 2014/09/08 15:20:19, timvolodine wrote: > could you add this comment directly above LightSensorIntervalMillis? Done.
	23 // content/renderer/device_sensors/device_light_event_pump.cc

21 const int kInertialSensorIntervalMillis = 50;	24 const int kInertialSensorIntervalMillis = 50;

	25 const int kInertialLightSensorIntervalMillis = 200;
	timvolodine 2014/09/08 15:20:19 remove "inertial" from the name. remove "inertial" from the name. riju_ 2014/09/09 14:01:18 Done. Show quoted text On 2014/09/08 15:20:19, timvolodine wrote: > remove "inertial" from the name. Done.
22	26

23 } // namespace content	27 } // namespace content

24	28

25 #endif // CONTENT_BROWSER_DEVICE_SENSORS_INERTIAL_SENSOR_CONSTS_H_	29 #endif // CONTENT_BROWSER_DEVICE_SENSORS_INERTIAL_SENSOR_CONSTS_H_

OLD	NEW