[DeviceLight] Browser+java part

content/browser/device_sensors/data_fetcher_shared_memory_default.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "data_fetcher_shared_memory.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 
 namespace {
@@ skipping 16 matching lines @@
   buffer->data.allAvailableSensorsAreActive = enabled;
   buffer->seqlock.WriteEnd();
   return true;
 }
 
 }  // namespace
 
 namespace content {
 
 DataFetcherSharedMemory::DataFetcherSharedMemory()
-    : motion_buffer_(NULL), orientation_buffer_(NULL) {
+    : motion_buffer_(NULL), orientation_buffer_(NULL), light_buffer_(NULL) {
 }
 
 DataFetcherSharedMemory::~DataFetcherSharedMemory() {
 }
 
 bool DataFetcherSharedMemory::Start(ConsumerType consumer_type, void* buffer) {
   DCHECK(buffer);
 
   switch (consumer_type) {
     case CONSUMER_TYPE_MOTION:
       motion_buffer_ = static_cast<DeviceMotionHardwareBuffer*>(buffer);
       UMA_HISTOGRAM_BOOLEAN("InertialSensor.MotionDefaultAvailable", false);
       return SetMotionBuffer(motion_buffer_, true);
     case CONSUMER_TYPE_ORIENTATION:
       orientation_buffer_ =
           static_cast<DeviceOrientationHardwareBuffer*>(buffer);
       UMA_HISTOGRAM_BOOLEAN("InertialSensor.OrientationDefaultAvailable",
           false);
       return SetOrientationBuffer(orientation_buffer_, true);
+    case CONSUMER_TYPE_LIGHT:
+      return true;

[timvolodine, 2014/09/04 17:16:57]

I assume this is for non-android platforms. Should the API return Inf in that
case? as it is now it looks like javascript will never get a callback.

[riju_, 2014/09/08 09:26:17]

Ok, putting inf in the light buffer.

     default:
       NOTREACHED();
   }
   return false;
 }
 
 bool DataFetcherSharedMemory::Stop(ConsumerType consumer_type) {
   switch (consumer_type) {
     case CONSUMER_TYPE_MOTION:
       return SetMotionBuffer(motion_buffer_, false);
     case CONSUMER_TYPE_ORIENTATION:
       return SetOrientationBuffer(orientation_buffer_, false);
+    case CONSUMER_TYPE_LIGHT:
+      return light_buffer_;

[timvolodine, 2014/09/04 17:16:57]

so this will return false because light_buffer_==0?

[riju_, 2014/09/08 09:26:17]

Done.

     default:
       NOTREACHED();
   }
   return false;
 }
 
 }  // namespace content