arc: Start ARC for Public Session users.

components/arc/arc_util.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_UTIL_H_
 #define COMPONENTS_ARC_ARC_UTIL_H_
 
 // This file contains utility to see ARC functionality status controlled by
 // outside of ARC, e.g. CommandLine flag, attribute of global data/state,
 // users' preferences, and FeatureList.
@@ skipping 58 matching lines @@
 // SetUpCommandLine(), and its argument should be passed to this function.
 // Also, in unittests, this can be called in SetUp() with
 // base::CommandLine::ForCurrentProcess().
 // |command_line| must not be nullptr.
 void SetArcAvailableCommandLineForTesting(base::CommandLine* command_line);
 
 // Returns true if ARC should run under Kiosk mode for the current profile.
 // As it can return true only when user is already initialized, it implies
 // that ARC availability was checked before and IsArcKioskAvailable()
 // should also return true in that case.
 bool IsArcKioskMode();

[Luis Héctor Chávez, 2017/08/29 16:24:09]

This _should_ now be unused. Can you remove it?

There are also mentions of kiosk mode in
https://cs.chromium.org/chromium/src/ash/metrics/user_metrics_recorder.cc?q=I...
, should those also be updated?

[Sergey Poromov, 2017/08/29 16:37:30]

IsArcKioskMode() is used in
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/arc/arc_session_...
that should be done for Public Sessions.

What about UserMetricsRecorder - this code is in another component, so probably
the check should be left there.

 
+// Returns true if current user is a public session.
+// In that case ARC should also be started if available, using the same
+// authentication flow as ARC Kiosk mode.
+bool IsPublicSessionMode();

[Luis Héctor Chávez, 2017/08/29 16:24:09]

IIUC this is unused. Can you remove it?

[Sergey Poromov, 2017/08/29 16:37:30]

Done.

+
+// Returns true if current user is a robot account user.
+// These are Public Session and ARC Kiosk users.
+// The check is basically IsArcKioskMode() | IsPublicSessionMode().
+bool IsRobotAccountMode();
+
 // Returns true if ARC is allowed for the given user. Note this should not be
 // used as a signal of whether ARC is allowed alone because it only considers
 // user meta data. e.g. a user could be allowed for ARC but if the user signs in
 // as a secondary user or signs in to create a supervised user, ARC should be
 // disabled for such cases.
 bool IsArcAllowedForUser(const user_manager::User* user);
 
 // Checks if opt-in verification was disabled by switch in command line.
 // In most cases, it is disabled for testing purpose.
 bool IsArcOptInVerificationDisabled();
 
 // Returns true if the |window|'s aura::client::kAppType is ARC_APP. When
 // |window| is nullptr, returns false.
 bool IsArcAppWindow(aura::Window* window);
 
 // Adjusts the amount of CPU the ARC instance is allowed to use. When
 // |do_restrict| is true, the limit is adjusted so ARC can only use tightly
 // restricted CPU resources.
 // TODO(yusukes): Use enum instead of bool.
 void SetArcCpuRestriction(bool do_restrict);
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_UTIL_H_